On 09/24/14 08:40, Aldy Hernandez wrote:
On 09/18/14 12:39, Aldy Hernandez wrote:
Yeah, sure, either way it's a good cleanup ;).
No strong opinions. Though I think true/false are the way we want folks
to write new code. Given that's the long term direction, might as well
fix that nit for DE
On 09/18/14 12:39, Aldy Hernandez wrote:
Yeah, sure, either way it's a good cleanup ;).
No strong opinions. Though I think true/false are the way we want folks
to write new code. Given that's the long term direction, might as well
fix that nit for DECL_ABSTRACT_P.
Alright... fixed.
OK?
Yeah, sure, either way it's a good cleanup ;).
No strong opinions. Though I think true/false are the way we want folks
to write new code. Given that's the long term direction, might as well
fix that nit for DECL_ABSTRACT_P.
Alright... fixed.
OK?
commit 276bf40161769e0485854576073aff9f35b16
On 09/18/14 10:33, Marek Polacek wrote:
On Thu, Sep 18, 2014 at 10:30:30AM -0600, Aldy Hernandez wrote:
- DECL_ABSTRACT (fn) = 1;
+ DECL_ABSTRACT_P (fn) = 1;
It'd probably make sense to use 'true' now.
I thought about it, but I wanted to change as little as possible, plus I
wanted to fol
On Thu, Sep 18, 2014 at 10:30:30AM -0600, Aldy Hernandez wrote:
>
> >>- DECL_ABSTRACT (fn) = 1;
> >>+ DECL_ABSTRACT_P (fn) = 1;
> >
> >It'd probably make sense to use 'true' now.
>
> I thought about it, but I wanted to change as little as possible, plus I
> wanted to follow the same style as wh
- DECL_ABSTRACT (fn) = 1;
+ DECL_ABSTRACT_P (fn) = 1;
It'd probably make sense to use 'true' now.
I thought about it, but I wanted to change as little as possible, plus I
wanted to follow the same style as what we've been doing for a lot of
the _P macros:
DECL_HAS_VALUE_EXPR_P (t) = 1;
On Thu, Sep 18, 2014 at 10:11:24AM -0600, Aldy Hernandez wrote:
> Similarly named DECL_ABSTRACT, DECL_ABSTRACT_ORIGIN, and DECL_ORIGIN are
> somewhat confusing to my poor brain. Particularly annoying is DECL_ABSTRACT
> which is actually a boolean, unlike the other two.
>
> Would it be OK to renam
Similarly named DECL_ABSTRACT, DECL_ABSTRACT_ORIGIN, and DECL_ORIGIN are
somewhat confusing to my poor brain. Particularly annoying is
DECL_ABSTRACT which is actually a boolean, unlike the other two.
Would it be OK to rename it something more sensible like
DECL_ABSTRACT_P? I know this is a l
