Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-24 Thread Andrew MacLeod via Gcc-patches
On 8/24/20 5:53 PM, Jeff Law wrote: On Wed, 2020-08-05 at 17:41 +0200, Aldy Hernandez wrote: On 8/5/20 5:09 PM, Martin Jambor wrote: On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: [...] * ipa-cp changes from vec to std::vec. We are using std::vec to ensure constructors are run,

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-24 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-05 at 17:41 +0200, Aldy Hernandez wrote: > On 8/5/20 5:09 PM, Martin Jambor wrote: > > > On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: > > > > [...] > > > > > * ipa-cp changes from vec to std::vec. > > > > > > We are using std::vec to ensure constructors are run, wh

Re: [patch] multi-range implementation for value_range (irange)

2020-08-10 Thread Aldy Hernandez via Gcc-patches
On 8/10/20 12:22 PM, Gerald Pfeifer wrote: On Mon, 10 Aug 2020, Aldy Hernandez wrote: My bad. I thought Gerald had committed the inline fix as well. Oh, and I thought you were going to after my success report. :-) (I did not run into problems because my own tester passed since I still had

Re: [patch] multi-range implementation for value_range (irange)

2020-08-10 Thread Martin Liška
On 8/10/20 12:22 PM, Gerald Pfeifer wrote: If your test bootstraping with GCC passes, I think (especially as the original author of this code) you can invoke the obvious rule and go ahead. Yes, I would also consider it an obvious change. Martin

Re: [patch] multi-range implementation for value_range (irange)

2020-08-10 Thread Gerald Pfeifer
On Mon, 10 Aug 2020, Aldy Hernandez wrote: > My bad. I thought Gerald had committed the inline fix as well. Oh, and I thought you were going to after my success report. :-) (I did not run into problems because my own tester passed since I still had your patch locally.9 > OK pending tests? > >

Re: [patch] multi-range implementation for value_range (irange)

2020-08-10 Thread Aldy Hernandez via Gcc-patches
On 8/10/20 5:42 AM, Martin Liška wrote: On 8/5/20 4:27 PM, Gerald Pfeifer wrote: Hi Aldy, On Fri, 31 Jul 2020, Aldy Hernandez via Gcc-patches wrote: Jeff approved this patch off-list.  I will re-run tests once again and commit by Monday. I believe this has broken the bootstrap with clang

Re: [patch] multi-range implementation for value_range (irange)

2020-08-09 Thread Martin Liška
On 8/5/20 4:27 PM, Gerald Pfeifer wrote: Hi Aldy, On Fri, 31 Jul 2020, Aldy Hernandez via Gcc-patches wrote: Jeff approved this patch off-list. I will re-run tests once again and commit by Monday. I believe this has broken the bootstrap with clang (specifically FreeBSD clang version 10.0.0):

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-06 Thread Aldy Hernandez via Gcc-patches
On 8/6/20 8:57 AM, Richard Biener wrote: On Thu, Aug 6, 2020 at 3:07 AM Andrew MacLeod wrote: On 8/5/20 12:54 PM, Richard Biener via Gcc-patches wrote: On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor wrote: On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: [...] * ipa-cp

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-06 Thread Jonathan Wakely via Gcc-patches
On 06/08/20 08:57 +0200, Richard Biener wrote: On Thu, Aug 6, 2020 at 3:07 AM Andrew MacLeod wrote: On 8/5/20 12:54 PM, Richard Biener via Gcc-patches wrote: > On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor wrote: >> On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: >> [...] >

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Richard Biener via Gcc-patches
On Thu, Aug 6, 2020 at 3:07 AM Andrew MacLeod wrote: > > On 8/5/20 12:54 PM, Richard Biener via Gcc-patches wrote: > > On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor > > wrote: > >> On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: > >> [...] > >> > >>> * ipa-cp changes from vec

Re: [patch] multi-range implementation for value_range (irange)

2020-08-05 Thread Richard Sandiford
Gerald Pfeifer writes: > 2020-08-05 Gerald Pfeifer > > * ipa-fnsummary.c (INCLUDE_VECTOR): Define. > Remove direct inclusion of . OK, thanks. Richard > diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c > index 49bab04524b..59e52927151 100644 > --- a/gcc/ipa-fnsummar

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Andrew MacLeod via Gcc-patches
On 8/5/20 12:54 PM, Richard Biener via Gcc-patches wrote: On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor wrote: On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: [...] * ipa-cp changes from vec to std::vec. We are using std::vec to ensure constructors are run, which they are

Re: [patch] multi-range implementation for value_range (irange)

2020-08-05 Thread Gerald Pfeifer
[ Jeff, approval request below ] On Wed, 5 Aug 2020, Aldy Hernandez wrote: >> I believe this has broken the bootstrap with clang (specifically >> FreeBSD clang version 10.0.0): >> >> In file included from /scratch/tmp/gerald/GCC-HEAD/gcc/c/gimple-parser.c:44: >> In file included from /scratch/tmp/

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Richard Biener via Gcc-patches
On August 5, 2020 5:41:01 PM GMT+02:00, Aldy Hernandez via Gcc-patches wrote: >On 8/5/20 5:09 PM, Martin Jambor wrote: > >> On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: >>> >> >> [...] >> >>> >>> * ipa-cp changes from vec to std::vec. >>> >>> We are using std::vec to ensure constr

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Richard Biener via Gcc-patches
On August 5, 2020 5:09:19 PM GMT+02:00, Martin Jambor wrote: >On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: >> > >[...] > >> >> * ipa-cp changes from vec to std::vec. >> >> We are using std::vec to ensure constructors are run, which they >aren't >> in our internal vec<> implementatio

Re: [patch] multi-range implementation for value_range (irange)

2020-08-05 Thread Aldy Hernandez via Gcc-patches
On 8/5/20 4:27 PM, Gerald Pfeifer wrote: Hi Aldy, On Fri, 31 Jul 2020, Aldy Hernandez via Gcc-patches wrote: Jeff approved this patch off-list. I will re-run tests once again and commit by Monday. I believe this has broken the bootstrap with clang (specifically FreeBSD clang version 10.0.

Re: std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Aldy Hernandez via Gcc-patches
On 8/5/20 5:09 PM, Martin Jambor wrote: On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: [...] * ipa-cp changes from vec to std::vec. We are using std::vec to ensure constructors are run, which they aren't in our internal vec<> implementation. Although we usually steer away fr

std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

2020-08-05 Thread Martin Jambor
On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote: > [...] > > * ipa-cp changes from vec to std::vec. > > We are using std::vec to ensure constructors are run, which they aren't > in our internal vec<> implementation. Although we usually steer away > from using std::vec because of inte

Re: [patch] multi-range implementation for value_range (irange)

2020-08-05 Thread Gerald Pfeifer
Hi Aldy, On Fri, 31 Jul 2020, Aldy Hernandez via Gcc-patches wrote: > Jeff approved this patch off-list. I will re-run tests once again and > commit by Monday. I believe this has broken the bootstrap with clang (specifically FreeBSD clang version 10.0.0): In file included from /scratch/tmp/ger