Re: [patch] move htab_iterator

2013-10-02 Thread Andrew MacLeod
On 10/01/2013 05:04 PM, DJ Delorie wrote: I'm typically against adding things to libiberty "because there's no other place for them". The purpose of libiberty is to provide a portability layer, not a trash can. However, htab is already in there, and the argument for putting its accessors there

Re: [patch] move htab_iterator

2013-10-01 Thread DJ Delorie
I'm typically against adding things to libiberty "because there's no other place for them". The purpose of libiberty is to provide a portability layer, not a trash can. However, htab is already in there, and the argument for putting its accessors there is sound. However, most of the other funct

Fwd: Fwd: Re: [patch] move htab_iterator

2013-10-01 Thread Andrew MacLeod
bounced from gcc-patches... must have been some html creep in.. Andrew Original Message Subject:Fwd: Re: [patch] move htab_iterator Date: Tue, 01 Oct 2013 16:54:52 -0400 From: Andrew MacLeod To: gcc-patches , tromey , Ian Lance Taylor , DJ Delorie Anyone

Re: [patch] move htab_iterator

2013-10-01 Thread Tom Tromey
> "Andrew" == Andrew MacLeod writes: Andrew> Sure, how's this? Thanks! Andrew> And who has to approve the libiberty bits? libiberty DJ Delorie d...@redhat.com libiberty Ian Lance Taylori...@airs.com Tom

Re: [patch] move htab_iterator

2013-09-30 Thread Andrew MacLeod
On 09/30/2013 01:02 PM, Tom Tromey wrote: Tom> How about putting it into libiberty? Tom> That way other hashtab users, like gdb, can use it. Andrew> I have no problem with that, but Jakub didn't seem to think it Andrew> belonged there. All I found was this: http://gcc.gnu.org/ml/gcc-patches/20

Re: [patch] move htab_iterator

2013-09-30 Thread Tom Tromey
Tom> How about putting it into libiberty? Tom> That way other hashtab users, like gdb, can use it. Andrew> I have no problem with that, but Jakub didn't seem to think it Andrew> belonged there. All I found was this: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00721.html Quoting from it: "It do

Re: [patch] move htab_iterator

2013-09-30 Thread Andrew MacLeod
On 09/30/2013 12:08 PM, Tom Tromey wrote: "Andrew" == Andrew MacLeod writes: Andrew> Jakub didn't like removing this hash table iterator functionality even Andrew> though it is currently unused in the compiler. Andrew> So it seems reasonable to put it in tree-hasher.h since its purpose is Andr

Re: [patch] move htab_iterator

2013-09-30 Thread Tom Tromey
> "Andrew" == Andrew MacLeod writes: Andrew> Jakub didn't like removing this hash table iterator functionality even Andrew> though it is currently unused in the compiler. Andrew> So it seems reasonable to put it in tree-hasher.h since its purpose is Andrew> "Hash Table Helper for Trees"? Ho

[patch] move htab_iterator

2013-09-30 Thread Andrew MacLeod
Jakub didn't like removing this hash table iterator functionality even though it is currently unused in the compiler. So it seems reasonable to put it in tree-hasher.h since its purpose is "Hash Table Helper for Trees"? bootstraps on build/x86_64-unknown-linux-gnu with no new regressions. O