Re: [patch] libstdc++/59603 Prevent self-swapping in random_shuffle

2014-12-06 Thread Jonathan Wakely
On 1 October 2014 at 13:35, Jonathan Wakely wrote: > On 12/09/14 14:34 +0100, Jonathan Wakely wrote: >> >> Swapping an object with itself is pointless, and asserts in debug mode >> (but we should probably remove that check from debug mode, since it >> can happen in reasonable code). >> >> Tested x

Re: [patch] libstdc++/59603 Prevent self-swapping in random_shuffle

2014-10-01 Thread Jonathan Wakely
On 12/09/14 14:34 +0100, Jonathan Wakely wrote: Swapping an object with itself is pointless, and asserts in debug mode (but we should probably remove that check from debug mode, since it can happen in reasonable code). Tested x86_64-linux, committed to trunk. I think this makes sense for the br

[patch] libstdc++/59603 Prevent self-swapping in random_shuffle

2014-09-12 Thread Jonathan Wakely
Swapping an object with itself is pointless, and asserts in debug mode (but we should probably remove that check from debug mode, since it can happen in reasonable code). Tested x86_64-linux, committed to trunk. I think this makes sense for the branches too, so will backport it soon. commit 0a25