Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
> On 3 Nov 2020, at 11:25, Jakub Jelinek wrote: > > Ok, thanks. Thanks Jakub! I have a couple of similar ones (for fpic) for non-target-specific tests in preparation. Then JIC, two smaller ones in the same spirit already sent: https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557477.ht

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 03, 2020 at 11:24:24AM +0100, Olivier Hainque wrote: > > > > On 3 Nov 2020, at 09:30, Jakub Jelinek wrote: > > > 70% of the tests you've changed have a target *-linux* or similar > > right above that line, what is the point of adding the fpic > > effective targets to those? Those s

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
> On 3 Nov 2020, at 09:30, Jakub Jelinek wrote: > 70% of the tests you've changed have a target *-linux* or similar > right above that line, what is the point of adding the fpic > effective targets to those? Those surely aren't run on vxWorks > and on x86 Linux fpic is always supported. Good

Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Jakub Jelinek via Gcc-patches
On Tue, Nov 03, 2020 at 09:25:03AM +0100, Olivier Hainque wrote: > Hello, > > This change is a proposal to add > > /* { dg-require-effective-target fpic } */ > > to tests in gcc.target/i386 that do use -fpic or -fPIC > but don't currently query the target support. > > This corresponds to wha

[patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests

2020-11-03 Thread Olivier Hainque
Hello, This change is a proposal to add /* { dg-require-effective-target fpic } */ to tests in gcc.target/i386 that do use -fpic or -fPIC but don't currently query the target support. This corresponds to what many other fpic tests do and helps the vxWorks ports at least, as -fpic is typicall