Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-21 Thread Jonathan Wakely
On 21 January 2014 10:00, Jonathan Wakely wrote: > On 20 January 2014 21:11, François Dumont wrote: >> On 01/20/2014 04:53 PM, Jonathan Wakely wrote: >> >> With this new design couldn't we change the conditions that are used to >> decide when to cache the hash code. I haven't study it in detail bu

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-21 Thread Jonathan Wakely
On 20 January 2014 21:11, François Dumont wrote: > On 01/20/2014 04:53 PM, Jonathan Wakely wrote: > > With this new design couldn't we change the conditions that are used to > decide when to cache the hash code. I haven't study it in detail but it > looks like the default constructible constraint

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-20 Thread François Dumont
On 01/20/2014 04:53 PM, Jonathan Wakely wrote: On 17 January 2014 15:11, Jonathan Wakely wrote: The issue in PR 56267 is that unordered_xxx::local_iterator sometimes inherits from the user-defined hash function (via _Hash_code_base, which inherits from the hash function to use the EBO), and loca

Re: [patch] fix libstdc++/56267 - local iterator requirements

2014-01-20 Thread Jonathan Wakely
On 17 January 2014 15:11, Jonathan Wakely wrote: > The issue in PR 56267 is that unordered_xxx::local_iterator sometimes > inherits from the user-defined hash function (via _Hash_code_base, > which inherits from the hash function to use the EBO), and > local_iterator must be DefaultConstructible an

[patch] fix libstdc++/56267 - local iterator requirements

2014-01-17 Thread Jonathan Wakely
The issue in PR 56267 is that unordered_xxx::local_iterator sometimes inherits from the user-defined hash function (via _Hash_code_base, which inherits from the hash function to use the EBO), and local_iterator must be DefaultConstructible and Assignable, even when the hash function isn't. My solu