Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-14 Thread Joseph S. Myers
On Wed, 14 May 2014, Manuel López-Ibáñez wrote: > Am I missing something? No, that seems sufficient (together with the observation that the target handlers remain called after the others, so while there may be such bugs involving them those bugs are irrelevant to this patch). The patch is OK

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-14 Thread Matthias Klose
Am 12.05.2014 19:30, schrieb Joseph S. Myers: > On Mon, 12 May 2014, Matthias Klose wrote: > >> I didn't look close enough to the gfortran test results. PR driver/61126 is >> a >> fix for the regression introduced with the fix for the above issue. With >> this >> patch proposed by Manuel, gfor

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-14 Thread Manuel López-Ibáñez
On 12 May 2014 22:24, Joseph S. Myers wrote: > On Mon, 12 May 2014, Manuel López-Ibáñez wrote: > >> I will be very surprised if the common defaults are overriding a FE >> default and it is not a bug in the FE. > > Well, I think that needs justification, not just "very surprised". > Identify (presu

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Joseph S. Myers
On Mon, 12 May 2014, Manuel López-Ibáñez wrote: > I will be very surprised if the common defaults are overriding a FE > default and it is not a bug in the FE. Well, I think that needs justification, not just "very surprised". Identify (presumably in an automated way) all the cases where an opti

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Manuel López-Ibáñez
On 12/05/2014, Joseph S. Myers wrote: > On Mon, 12 May 2014, Matthias Klose wrote: > >> I didn't look close enough to the gfortran test results. PR driver/61126 >> is a >> fix for the regression introduced with the fix for the above issue. With >> this >> patch proposed by Manuel, gfortran.dg/we

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Joseph S. Myers
On Mon, 12 May 2014, Matthias Klose wrote: > I didn't look close enough to the gfortran test results. PR driver/61126 is a > fix for the regression introduced with the fix for the above issue. With this > patch proposed by Manuel, gfortran.dg/wextra_1.f now passes, and no new > regressions seen

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Matthias Klose
Am 08.05.2014 23:36, schrieb Joseph S. Myers: > On Thu, 8 May 2014, Matthias Klose wrote: > >> This fixes a regression introduced with 4.8, where the option ordering >> of -Wextra and -Wunused-parameter emits a warning, which is not emitted >> with 4.7. No regressions with the trunk, the 4.9 and

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-09 Thread Dominique Dhumieres
> This fixes a regression introduced with 4.8, ... This caused pr61126. Dominique

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-08 Thread Joseph S. Myers
On Thu, 8 May 2014, Matthias Klose wrote: > This fixes a regression introduced with 4.8, where the option ordering > of -Wextra and -Wunused-parameter emits a warning, which is not emitted > with 4.7. No regressions with the trunk, the 4.9 and 4.8 branches. Ok to > check in for these? OK. --

[patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-08 Thread Matthias Klose
This fixes a regression introduced with 4.8, where the option ordering of -Wextra and -Wunused-parameter emits a warning, which is not emitted with 4.7. No regressions with the trunk, the 4.9 and 4.8 branches. Ok to check in for these? Matthias 2014-05-08 Manuel Lpez-Ibez Matthi