Re: [patch] fix darwin bootstrap by avoiding duplicate DIE attributes

2015-06-12 Thread Aldy Hernandez
On 06/12/2015 12:22 AM, Andreas Schwab wrote: ../../gcc/dwarf2out.c:5693:1: error: 'void check_die(dw_die_ref)' defined but not used [-Werror=unused-function] Andreas. Committed as obvious. commit 76da2378b15ad786e8c2c64ddd8b39c132947738 Author: Aldy Hernandez Date: Fri Jun 12 06:42:08 20

Re: [patch] fix darwin bootstrap by avoiding duplicate DIE attributes

2015-06-12 Thread Andreas Schwab
../../gcc/dwarf2out.c:5693:1: error: 'void check_die(dw_die_ref)' defined but not used [-Werror=unused-function] Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: [patch] fix darwin bootstrap by avoiding duplicate DIE attributes

2015-06-11 Thread Jason Merrill
OK. Jason

Re: [patch] fix darwin bootstrap by avoiding duplicate DIE attributes

2015-06-11 Thread Aldy Hernandez
Hi Jason. Attached is a new patch with the off-list corrections. Tested on x86_64 Linux. Aldy commit 1775f74c2b78b1601c89befa724114d89fc2e8be Author: Aldy Hernandez Date: Tue Jun 9 18:07:44 2015 -0400 PR bootstrap/66448 * dwarf2out.c (check_die): Check for common duplicate a

[patch] fix darwin bootstrap by avoiding duplicate DIE attributes

2015-06-11 Thread Aldy Hernandez
Hi. As explained in the PR, this patch fixes all the duplicate DIE attribute issues seen in Darwin. This patch fixes real problems on Linux as well, but they're silently ignored by Linux's more permissive linker. I have enhanced check_die() to check for these duplicate attributes in the fut