Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Olivier Hainque
> On 11 Jun 2018, at 11:24, Jakub Jelinek wrote: > > On Mon, Jun 11, 2018 at 08:50:31AM +0200, Olivier Hainque wrote: >> FWIW, I was surprised by a gotcha while writing tests for this, >> where both >> >> { dg-final { scan-assembler "0x3.*DW_AT_language" } } >> and { dg-final { scan-ass

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Jakub Jelinek
On Mon, Jun 11, 2018 at 08:50:31AM +0200, Olivier Hainque wrote: > FWIW, I was surprised by a gotcha while writing tests for this, > where both > > { dg-final { scan-assembler "0x3.*DW_AT_language" } } > and { dg-final { scan-assembler "0xd.*DW_AT_language" } } > > matched for Ada95 (0xd)

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-11 Thread Olivier Hainque
> On 10 Jun 2018, at 21:26, Jakub Jelinek wrote: >> http://wiki.dwarfstd.org/index.php?title=DWARF_Language_Support > > Well, you should better be looking at the pdfs of the standards, that is > more precise. Ok > And there it says: > Names marked with † and their associated values are reser

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-10 Thread Jakub Jelinek
On Sun, Jun 10, 2018 at 09:26:51AM +0200, Olivier Hainque wrote: > Hi Jakub, > > > On 07 Jun 2018, at 10:36, Jakub Jelinek wrote: > > > The whole point of -gstrict-dwarf is that it doesn't allow any extensions, > > and DW_LANG_Ada83/DW_LANG_Ada95 only appeared in DWARF3. > > Actually, according

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-10 Thread Olivier Hainque
Hi Jakub, > On 07 Jun 2018, at 10:36, Jakub Jelinek wrote: > The whole point of -gstrict-dwarf is that it doesn't allow any extensions, > and DW_LANG_Ada83/DW_LANG_Ada95 only appeared in DWARF3. Actually, according to http://wiki.dwarfstd.org/index.php?title=DWARF_Language_Support DW_LANG_A

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Olivier Hainque
> On 07 Jun 2018, at 10:36, Jakub Jelinek wrote: > > No, this is just wrong. > The whole point of -gstrict-dwarf is that it doesn't allow any extensions, > and DW_LANG_Ada83/DW_LANG_Ada95 only appeared in DWARF3. Oh, I hadn't realized that. I see. > Perhaps don't use -gstrict-dwarf if you are

Re: [patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Jakub Jelinek
On Thu, Jun 07, 2018 at 10:31:29AM +0200, Olivier Hainque wrote: > Hello, > > dwarf2out currently prevents advertising DW_LANG_Ada if > version < 3 and strict_dwarf. There is no good reason for > this and it is detrimental to gdb on some VxWorks configurations. > > This patch just moves the DW_LA

[patch] dwarf2out don't discriminate on dwarf version for advertising Ada

2018-06-07 Thread Olivier Hainque
Hello, dwarf2out currently prevents advertising DW_LANG_Ada if version < 3 and strict_dwarf. There is no good reason for this and it is detrimental to gdb on some VxWorks configurations. This patch just moves the DW_LANG_Ada language selection out of the section guarded by the special version che