On Wed, Dec 12, 2012 at 01:41:49PM +0100, Steven Bosscher wrote:
> On Wed, Dec 12, 2012 at 1:17 PM, Steven Bosscher wrote:
> > I'll resubmit for GCC 4.9. Instead of a test case, I have a verifier
> > queued that asserts no BARRIERs appear in the insns stream when in
> > cfglayout mode. (This verifi
On Wed, Dec 12, 2012 at 1:17 PM, Steven Bosscher wrote:
> I'll resubmit for GCC 4.9. Instead of a test case, I have a verifier
> queued that asserts no BARRIERs appear in the insns stream when in
> cfglayout mode. (This verifier currently breaks hot-cold partitioning
> all over the place due to a b
On Wed, Dec 12, 2012 at 11:48 AM, Jakub Jelinek wrote:
>> The fixup_reorder_chain patch fixes and ICE with hot-cold partitioning
>> and GCAC checking. A BARRIER is removed somewhere along the line, but
>> the BB_FOOTER pointer still points to it. I'm not sure how things go
>> bad from there, but we
On Wed, Dec 12, 2012 at 11:29:28AM +0100, Steven Bosscher wrote:
> >> (fixup_reorder_chain): Set cfg_layout_function_header to NULL to
> >> avoid dangling pointers into GC-allocated insns. Clear BB_HEADER,
> >> BB_FOOTER, and cfg_layout_function_footer for the same reason.
On Wed, Dec 12, 2012 at 11:17 AM, Jakub Jelinek wrote:
>> * cfgrtl.c (rtl_verify_flow_info): Fix code style (indentation).
>
> This is undesirable, we generally don't fix indentation unless you touch
> the code (or very close surrounding code),
OK, I'll drop this then.
>> (fixup
On Thu, Dec 06, 2012 at 01:48:31PM +0100, Steven Bosscher wrote:
> * bitmap.h: Fix "set_difference" references in comment.
> * dse.c (dse_bitmap_obstack): Fix comment.
This is ok.
>
> * loop-invariant.c (record_use): Use DF_REF_REG_MEM_P instead of
> looking at spe
On Thu, Dec 06, 2012 at 01:48:31PM +0100, Steven Bosscher wrote:
> Hello,
>
> This patch has 3 parts:
>
> 1. Benign comment fixes.
>
> 2. Using DF_REF_REG_MEM_P idiom. Also benign.
>
> 3. Real bug fixes for cfglayout mode.
>
> For (3) the fixes are:
> - Pointers to the unlinked parts of the in
Ping?
On Thu, Dec 6, 2012 at 1:48 PM, Steven Bosscher wrote:
> Hello,
>
> This patch has 3 parts:
>
> 1. Benign comment fixes.
>
> 2. Using DF_REF_REG_MEM_P idiom. Also benign.
>
> 3. Real bug fixes for cfglayout mode.
>
> For (3) the fixes are:
> - Pointers to the unlinked parts of the insns chai
Hello,
This patch has 3 parts:
1. Benign comment fixes.
2. Using DF_REF_REG_MEM_P idiom. Also benign.
3. Real bug fixes for cfglayout mode.
For (3) the fixes are:
- Pointers to the unlinked parts of the insns chain are not cleared,
which results in complete RTL bodies being left not
garbage-co
