Re: [patch] backwards threader cleanups

2017-11-17 Thread Aldy Hernandez
On 11/15/2017 08:06 AM, Pedro Alves wrote: On 11/15/2017 07:34 AM, Aldy Hernandez wrote: On 11/14/2017 02:38 PM, David Malcolm wrote: On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: https://gcc.gnu.org/codingconventions.html#Class_Form says that: "When defining a class, fir

Re: [patch] backwards threader cleanups

2017-11-17 Thread Jeff Law
On 11/15/2017 12:34 AM, Aldy Hernandez wrote: > > > On 11/14/2017 02:38 PM, David Malcolm wrote: >> On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > >>    https://gcc.gnu.org/codingconventions.html#Class_Form >> says that: >> >> "When defining a class, first [...] >> declare all public

Re: [patch] backwards threader cleanups

2017-11-15 Thread Pedro Alves
On 11/15/2017 07:34 AM, Aldy Hernandez wrote: > > > On 11/14/2017 02:38 PM, David Malcolm wrote: >> On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > >>https://gcc.gnu.org/codingconventions.html#Class_Form >> says that: >> >> "When defining a class, first [...] >> declare all public

Re: [patch] backwards threader cleanups

2017-11-14 Thread Aldy Hernandez
On 11/14/2017 02:38 PM, David Malcolm wrote: On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: https://gcc.gnu.org/codingconventions.html#Class_Form says that: "When defining a class, first [...] declare all public member functions, [...] then declare all non-public member functio

Re: [patch] backwards threader cleanups

2017-11-14 Thread David Malcolm
On Tue, 2017-11-14 at 14:08 -0500, Aldy Hernandez wrote: > Howdy! > > For some upcoming work I need some pass local data that I don't want > to > be passing around as an argument. We have enough of those in the > threader as it is. So I moved the current pass local data into its > own > class

[patch] backwards threader cleanups

2017-11-14 Thread Aldy Hernandez
Howdy! For some upcoming work I need some pass local data that I don't want to be passing around as an argument. We have enough of those in the threader as it is. So I moved the current pass local data into its own class, and basically classified the entire pass, thus avoiding a lot of argu