Re: [patch] Tidy up RTL libfunc machinery

2016-05-13 Thread Eric Botcazou
> The middle-end parts are ok, I'm leaving backend parts for their > maintainers to comment > but those parts are ok as well if they do not comment within a > reasonable amount of time. Thanks, I have applied the patch. > Did you check the internals manual if it needs adjustment? The only relate

Re: [patch] Tidy up RTL libfunc machinery

2016-05-11 Thread Richard Biener
On Tue, May 10, 2016 at 10:12 PM, Eric Botcazou wrote: > Hi, > > this patch is aimed at cleaning up the mess with the RTL libfunc machinery. > > On the one hand you have comments like these in the RTL expander: > > /* It is incorrect to use the libcall calling conventions to call > memcpy i

[patch] Tidy up RTL libfunc machinery

2016-05-10 Thread Eric Botcazou
Hi, this patch is aimed at cleaning up the mess with the RTL libfunc machinery. On the one hand you have comments like these in the RTL expander: /* It is incorrect to use the libcall calling conventions to call memcpy in this context. This could be a user call to memcpy and the use