Re: [patch] Some testsuite cleanup

On 01/08/16 17:31 +0100, Jonathan Wakely wrote: On 01/08/16 09:23 -0700, Mike Stump wrote: On Jul 31, 2016, at 1:30 PM, Jonathan Wakely wrote: -fno-show-column is a good general option. If you guys want to add column number test cases, they can avoid it, and test down to the column. Most

Re: [patch] Some testsuite cleanup

On 01/08/16 09:23 -0700, Mike Stump wrote: On Jul 31, 2016, at 1:30 PM, Jonathan Wakely wrote: -fno-show-column is a good general option. If you guys want to add column number test cases, they can avoid it, and test down to the column. Most people don't care, and most test aren't interes

Re: [patch] Some testsuite cleanup

On Jul 31, 2016, at 1:30 PM, Jonathan Wakely wrote: > > -fno-show-column is a good general option. If you guys want to add column number test cases, they can avoid it, and test down to the column. Most people don't care, and most test aren't interested in column testing anyway. But, if you

Re: [patch] Some testsuite cleanup

On 28/07/16 22:06 +0100, Jonathan Wakely wrote: When I added _Temporary_object to vector recently I updated the construct/destroy counts in this test to match, but the changes only apply for C++11 and later. This makes the test pass whether run as C++98 or C++11 and later. Fix std::vector test

Re: [patch] Some testsuite cleanup

On 31/07/16 20:21 +0100, Jonathan Wakely wrote: (I'm getting really annoyed with line numbers matching columns!) testsuite/20_util/pair/cons/explicit_construct.cc is another one where this happens. If you remove a blank line near the top of the file it starts FAILing, because the error at expli

Re: [patch] Some testsuite cleanup

On 28/07/16 22:06 +0100, Jonathan Wakely wrote: The dg-options for FreeBSD and Dragonfly should have included -std=gnu++11, or should have used dg-additional-options to add to, rather than override, the common dg-options. Use dg-additional-options in libstdc++ tests * testsuite/17_intro/

Re: [patch] Some testsuite cleanup

On 28/07/16 22:06 +0100, Jonathan Wakely wrote: The dg-prune-output directives in these tests are needed to prune some additional errors that are only issued in C++98 mode, but the line numbers had got out of date. I've replaced the hardcoded numbers with strings that will stay valid. Fix DR 4

[patch] Some testsuite cleanup

This is a set of small patches for issues in the testsuite that I noticed while working on a big change (coming soon). Self-explanatory: Fix invalid dg-do directives in libstdc++ tests * testsuite/22_locale/conversions/string/1.cc: Remove unintended dg-do compile directive.