Re: [patch] Remap goto_locus on edges during inlining

2018-06-28 Thread Eric Botcazou
> Yes, OK if it (hopefully!) passes testing. Yes, it passed bootstrap/regtest on x86-64/Linux so was applied. -- Eric Botcazou

Re: [patch] Remap goto_locus on edges during inlining

2018-06-28 Thread Richard Biener
On Thu, Jun 28, 2018 at 12:46 PM Eric Botcazou wrote: > > > Related we're also missing to verify_location () on those in > > verify_gimple_in_cfg. Having stale references to GCed BLOCKs > > via locations can be difficult to track down... > > > > So can you add the verification bits as well? > > L

Re: [patch] Remap goto_locus on edges during inlining

2018-06-28 Thread Eric Botcazou
> Related we're also missing to verify_location () on those in > verify_gimple_in_cfg. Having stale references to GCed BLOCKs > via locations can be difficult to track down... > > So can you add the verification bits as well? Like this? * tree-cfg.c (verify_gimple_in_cfg): Call verify_

Re: [patch] Remap goto_locus on edges during inlining

2018-06-28 Thread Richard Biener
On Tue, Jun 26, 2018 at 10:12 PM Jeff Law wrote: > > On 06/26/2018 02:54 AM, Eric Botcazou wrote: > > Hi, > > > > this makes sure the goto_locus present (or not) on edges is properly > > remapped > > during inlining. > > > > Tested on x86-64/Linux, OK for the mainline? > > > > > > 2018-06-26 Eri

Re: [patch] Remap goto_locus on edges during inlining

2018-06-26 Thread Jeff Law
On 06/26/2018 02:54 AM, Eric Botcazou wrote: > Hi, > > this makes sure the goto_locus present (or not) on edges is properly remapped > during inlining. > > Tested on x86-64/Linux, OK for the mainline? > > > 2018-06-26 Eric Botcazou > > * tree-inline.c (remap_location): New function e

[patch] Remap goto_locus on edges during inlining

2018-06-26 Thread Eric Botcazou
Hi, this makes sure the goto_locus present (or not) on edges is properly remapped during inlining. Tested on x86-64/Linux, OK for the mainline? 2018-06-26 Eric Botcazou * tree-inline.c (remap_location): New function extracted from... (copy_edges_for_bb): Add ID parameter.