Re: [patch] PR54919 - fix variable expansion in RTL loop unrolling

2012-10-14 Thread Steven Bosscher
On Sun, Oct 14, 2012 at 11:11 AM, Eric Botcazou wrote: > OK, thanks (if you also add the testcase to gcc.dg with the special options). Thanks, committed as trunk r192439. Ciao! Steven

Re: [patch] PR54919 - fix variable expansion in RTL loop unrolling

2012-10-14 Thread Steven Bosscher
On Sun, Oct 14, 2012 at 4:18 PM, Jan Hubicka wrote: >> Tested with a bootstrapped compiler. Test coverage isn't great, >> because variable expansion is not enabled by default. > > Are there particular reasons to not enable it? It seems like usefull > optimization. I don't know of any reason not

Re: [patch] PR54919 - fix variable expansion in RTL loop unrolling

2012-10-14 Thread Jan Hubicka
> Hello, > > Today appears to be RTL loop optimizer patch day, because here's > another patch... > > The problem here is that variable expansion does not update REG_EQUAL > notes when it performs replacement of the renamed register. Hehe. or rather REG_EQUAL patch day :) It makes me wonder how m

Re: [patch] PR54919 - fix variable expansion in RTL loop unrolling

2012-10-14 Thread Eric Botcazou
> Today appears to be RTL loop optimizer patch day, because here's > another patch... > > The problem here is that variable expansion does not update REG_EQUAL > notes when it performs replacement of the renamed register. > > I fixed this by using validate_replace_rtx_group(). There is already >

[patch] PR54919 - fix variable expansion in RTL loop unrolling

2012-10-13 Thread Steven Bosscher
Hello, Today appears to be RTL loop optimizer patch day, because here's another patch... The problem here is that variable expansion does not update REG_EQUAL notes when it performs replacement of the renamed register. I fixed this by using validate_replace_rtx_group(). There is already code in