Re: [patch] PR target/54160: Only set __OBJC2__ when compiling OBJC.

2012-12-05 Thread Mike Stump
On Dec 5, 2012, at 10:22 AM, Aldy Hernandez wrote: > Adjusted ChangeLog entry as suggested by Jakub on IRC. > > OK? Ok. Please watch for hate mail from cpp folks that don't want internal being used in this way…

Re: [patch] PR target/54160: Only set __OBJC2__ when compiling OBJC.

2012-12-05 Thread Aldy Hernandez
Adjusted ChangeLog entry as suggested by Jakub on IRC. OK? commit ddc4494409331e5a75814a6c8a57aa0646257fb2 Author: Aldy Hernandez Date: Wed Dec 5 08:38:10 2012 -0600 PR target/54160 * config/t-darwin (darwin-c.o): Depend on $(CPP_INTERNAL_H). * config/darwin-c.c (darwi

Re: [patch] PR target/54160: Only set __OBJC2__ when compiling OBJC.

2012-12-05 Thread Aldy Hernandez
Hi gentlemen. Just in case you missed this post. This only affects Darwin, so it's technically not just an Objective C problem. This problem came about with Ian Sandoe's patch of rev@170260. The CPP builtin "__OBJC2__" is only set for Darwin. FYI, in this patch I followed the way we curre

[patch] PR target/54160: Only set __OBJC2__ when compiling OBJC.

2012-12-04 Thread Aldy Hernandez
The problem here is that we are setting __OBJC2__ regardless of what language we are compiling. Tested by building a cross cc1/cc1obj for x86_64-unknown-darwin, and doing the following: reynosa:/build/trunk-darwin-objc/gcc$ echo "" | ./cc1obj -E -dM - -quiet |grep OBJ #define __OBJC__ 1 #d