Re: [patch] PR pch/53880

2012-07-31 Thread Steven Bosscher
On Tue, Jul 31, 2012 at 7:04 AM, Laurynas Biveinis wrote: > Steven - > >> Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? > > Thanks for working on this. It looks good, couple of minor comments: Thanks for the review. I've made the adjustments you suggested and committed the pat

Re: [patch] PR pch/53880

2012-07-30 Thread Laurynas Biveinis
Steven - > Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Thanks for working on this. It looks good, couple of minor comments: Please add an assert that d->have_this_obj == true in write_types_local_process_field, before the oprintf that outputs "this_obj". > @@ -3444,6 +3449

[patch] PR pch/53880

2012-07-30 Thread Steven Bosscher
Hello, This PR concerns a huge compile time regression since -ftrack-macro-expansion=2 became the default. It turns out that gengtype generates code that is quadratic in the GTY((length)) of arrays, and in this case (a PCH for a Boost header...) there are 183k maps for macro expansion line maps in