Re: [patch] PR debug/53948

2012-12-18 Thread Richard Biener
On Wed, Jul 18, 2012 at 7:46 PM, Steven Bosscher wrote: > Hello, > > This is my proposed fix for PR53948. We don't want to put user > variables in callee-clobbered registers, but obviously function > arguments are OK there. REG_USERVAR_P is set on PARM_DECLs and on user > variables, so it can't be

Re: [patch] PR debug/53948

2012-07-18 Thread Jakub Jelinek
On Wed, Jul 18, 2012 at 08:55:17PM +0200, Jan Kratochvil wrote: > On Wed, 18 Jul 2012 20:05:46 +0200, Steven Bosscher wrote: > > I wouldn't know what to test for. Looking for a .loc marker seems a bit > > fragile. > > What is fragile on > // { dg-final { scan-assembler-times "\\.loc\t1 3 0\\r\\n\

Re: [patch] PR debug/53948

2012-07-18 Thread Jan Kratochvil
On Wed, 18 Jul 2012 20:05:46 +0200, Steven Bosscher wrote: > I wouldn't know what to test for. Looking for a .loc marker seems a bit > fragile. What is fragile on // { dg-final { scan-assembler-times "\\.loc\t1 3 0\\r\\n\t\[^.\]" 6 } } or something like that. Line numbers are constant for the t

Re: [patch] PR debug/53948

2012-07-18 Thread Steven Bosscher
On Wed, Jul 18, 2012 at 7:55 PM, Jan Kratochvil wrote: > Hello Steven, > > On Wed, 18 Jul 2012 19:46:16 +0200, Steven Bosscher wrote: >> This is my proposed fix for PR53948. > > I can't speak for the GCC code but could it have a GCC testcase? I wouldn't know what to test for. Looking for a .loc m

Re: [patch] PR debug/53948

2012-07-18 Thread Jan Kratochvil
Hello Steven, On Wed, 18 Jul 2012 19:46:16 +0200, Steven Bosscher wrote: > This is my proposed fix for PR53948. I can't speak for the GCC code but could it have a GCC testcase? Thanks, Jan

[patch] PR debug/53948

2012-07-18 Thread Steven Bosscher
Hello, This is my proposed fix for PR53948. We don't want to put user variables in callee-clobbered registers, but obviously function arguments are OK there. REG_USERVAR_P is set on PARM_DECLs and on user variables, so it can't be used to distinguish between the two. As it turns out, I can hi-jac