Re: [patch] Minor improvement to fold_unary_loc

2014-05-15 Thread Jeff Law
On 05/15/14 08:15, Eric Botcazou wrote: Seems reasonable. Do you happen to have a testcase where you can see the effects in one of the dumps? That's not easy because NON_LVALUE_EXPRs are present only in .original and, at least in Ada, essentially only in size expressions which are not visible

Re: [patch] Minor improvement to fold_unary_loc

2014-05-15 Thread Eric Botcazou
> Seems reasonable. Do you happen to have a testcase where you can see > the effects in one of the dumps? That's not easy because NON_LVALUE_EXPRs are present only in .original and, at least in Ada, essentially only in size expressions which are not visible in the dump. -- Eric Botcazou

Re: [patch] Minor improvement to fold_unary_loc

2014-05-14 Thread Jeff Law
On 05/14/14 04:40, Eric Botcazou wrote: Hi, this makes fold_unary_loc fold NON_LVALUE_EXPR if the argument cannot be a lvalue (this happens when you're re-fold-building an existing tree) and changes the first call to fold_convert_const to use arg0 instead of op0, like the other 2 calls just belo

[patch] Minor improvement to fold_unary_loc

2014-05-14 Thread Eric Botcazou
Hi, this makes fold_unary_loc fold NON_LVALUE_EXPR if the argument cannot be a lvalue (this happens when you're re-fold-building an existing tree) and changes the first call to fold_convert_const to use arg0 instead of op0, like the other 2 calls just below (this should not change anything if t