Re: [patch] Hookize CFG DOT graph dumping

2012-12-04 Thread Steven Bosscher
On Tue, Dec 4, 2012 at 10:18 PM, Xinliang David Li wrote: > Was it a bug then? Yup, a bug. One I introduced myself with the passes.c changes. With the attached patch I get this dump: - 8< --- digraph "" { overlap=false; subgraph "foo" { color="black"; label="foo";

Re: [patch] Hookize CFG DOT graph dumping

2012-12-04 Thread Xinliang David Li
On Tue, Dec 4, 2012 at 12:47 PM, Steven Bosscher wrote: > On Tue, Dec 4, 2012 at 9:14 PM, Xinliang David Li wrote: >> I assume the graph dump does not support multiple function dump (I >> noticed that the previous function's dump gets overwritten). This >> reminds me that I need to resurrect my p

Re: [patch] Hookize CFG DOT graph dumping

2012-12-04 Thread Steven Bosscher
On Tue, Dec 4, 2012 at 9:14 PM, Xinliang David Li wrote: > I assume the graph dump does not support multiple function dump (I > noticed that the previous function's dump gets overwritten). This > reminds me that I need to resurrect my per-function dump support, and > dump-before/after patches at s

Re: [patch] Hookize CFG DOT graph dumping

2012-12-04 Thread Xinliang David Li
Nice. We used to just do post-processing of the dumps with -blocks option. I assume the graph dump does not support multiple function dump (I noticed that the previous function's dump gets overwritten). This reminds me that I need to resurrect my per-function dump support, and dump-before/after

Re: [patch] Hookize CFG DOT graph dumping

2012-12-04 Thread Richard Biener
On Mon, Dec 3, 2012 at 5:54 PM, Steven Bosscher wrote: > Hello, > > This is the last patch in this series for now, unless I can convince > everyone that some files should be renamed after all these changes :-) > > The attached patch makes graph.c independent of the IR contained in > the CFG it dum

[patch] Hookize CFG DOT graph dumping

2012-12-03 Thread Steven Bosscher
Hello, This is the last patch in this series for now, unless I can convince everyone that some files should be renamed after all these changes :-) The attached patch makes graph.c independent of the IR contained in the CFG it dumps. For this, I made the node label dumping routine a cfghook. I als