Re: [patch] Fix PR tree-optimization/70884

2016-05-20 Thread Richard Biener
On Fri, May 20, 2016 at 9:34 AM, Eric Botcazou wrote: >> Effectively, the patch prevents late-SRA from doing anything for both >> testcases (PR 70884 and PR 70919). I have started a bootstrap and >> testing on x86_64 and i686 only a few moments ago but it would be >> great if someone also tried o

Re: [patch] Fix PR tree-optimization/70884

2016-05-20 Thread Eric Botcazou
> Effectively, the patch prevents late-SRA from doing anything for both > testcases (PR 70884 and PR 70919). I have started a bootstrap and > testing on x86_64 and i686 only a few moments ago but it would be > great if someone also tried on an architecture for which the > constant-pool SRA enhance

Re: [patch] Fix PR tree-optimization/70884

2016-05-13 Thread Martin Jambor
Hi, On Fri, May 13, 2016 at 01:01:50PM +0200, Eric Botcazou wrote: > > Hmm, the patch looks obvious if it was the intent to allow constant > > pool replacements > > _not_ only when the whole constant pool entry may go away. But I > > think the intent was > > to not do this otherwise it will gener

Re: [patch] Fix PR tree-optimization/70884

2016-05-13 Thread Richard Biener
On Fri, May 13, 2016 at 1:01 PM, Eric Botcazou wrote: >> Hmm, the patch looks obvious if it was the intent to allow constant >> pool replacements >> _not_ only when the whole constant pool entry may go away. But I >> think the intent was >> to not do this otherwise it will generate worse code by

Re: [patch] Fix PR tree-optimization/70884

2016-05-13 Thread Eric Botcazou
> Hmm, the patch looks obvious if it was the intent to allow constant > pool replacements > _not_ only when the whole constant pool entry may go away. But I > think the intent was > to not do this otherwise it will generate worse code by forcing all > loads from the constant pool to appear at > fu

Re: [patch] Fix PR tree-optimization/70884

2016-05-09 Thread Richard Biener
On Sat, May 7, 2016 at 11:22 PM, Eric Botcazou wrote: > Hi, > > this is a tentative fix for the regression introduced in SRA by the machinery > which deals with the constant pool. initialize_constant_pool_replacements is > supposed to issues new loads from the pool for scalarized variables, but i

[patch] Fix PR tree-optimization/70884

2016-05-07 Thread Eric Botcazou
Hi, this is a tentative fix for the regression introduced in SRA by the machinery which deals with the constant pool. initialize_constant_pool_replacements is supposed to issues new loads from the pool for scalarized variables, but it fails to do so for variables that are only partially scalar