Re: [patch] Fix PR tree-optimization/56424

2013-03-04 Thread Richard Biener
On Fri, Mar 1, 2013 at 3:56 PM, Eric Botcazou wrote: >> But in theory this pessimizes code as aggregate_value_p returned true >> for this? That is, isn't the bug that we rewrite a possible >> return-slot-decl into SSA? (do we do that here?) > > Yes, aggregate_value_p returns true for this becaus

Re: [patch] Fix PR tree-optimization/56424

2013-03-01 Thread Eric Botcazou
> But in theory this pessimizes code as aggregate_value_p returned true > for this? That is, isn't the bug that we rewrite a possible > return-slot-decl into SSA? (do we do that here?) Yes, aggregate_value_p returns true for this because the ABI says that this type is returned in memory. And,

Re: [patch] Fix PR tree-optimization/56424

2013-03-01 Thread Richard Biener
On Fri, Mar 1, 2013 at 12:38 PM, Eric Botcazou wrote: > Hi, > > this is the ICE during the build of the Ada runtime on x86-64/Windows: the > compiler stops on the assertion in declare_return_variable: > > var = return_slot; > gcc_assert (TREE_CODE (var) != SSA_NAME); > > The pr

[patch] Fix PR tree-optimization/56424

2013-03-01 Thread Eric Botcazou
Hi, this is the ICE during the build of the Ada runtime on x86-64/Windows: the compiler stops on the assertion in declare_return_variable: var = return_slot; gcc_assert (TREE_CODE (var) != SSA_NAME); The problem stems for the fnsplit pass: it turns P.Sin (const long_long_flo