Re: [patch] Fix Fortran size_t parameter passing

2019-05-22 Thread Andrew Stubbs
On 22/05/2019 13:28, Janne Blomqvist wrote: Just to confirm, is the attached what you mean? Yes, looks good. Thanks, now committed. Andrew

Re: [patch] Fix Fortran size_t parameter passing

2019-05-22 Thread Janne Blomqvist
On Wed, May 22, 2019 at 3:20 PM Andrew Stubbs wrote: > > On 22/05/2019 12:35, Janne Blomqvist wrote: > > Thanks for the catch. Though for size_t you should use build_zero_cst > > (size_type_node). size_zero_node is a zero constant of type sizetype, > > which is not the same as size_type_node (size

Re: [patch] Fix Fortran size_t parameter passing

2019-05-22 Thread Andrew Stubbs
On 22/05/2019 12:35, Janne Blomqvist wrote: Thanks for the catch. Though for size_t you should use build_zero_cst (size_type_node). size_zero_node is a zero constant of type sizetype, which is not the same as size_type_node (size_t in C). Ok with that change. So, integer_zero_node is compatible

Re: [patch] Fix Fortran size_t parameter passing

2019-05-22 Thread Janne Blomqvist
On Wed, May 22, 2019 at 1:54 PM Andrew Stubbs wrote: > > This patch fixes a bug observed on amdgcn in which the Fortran frontend > creates function calls using the 32-bit parameters where they ought to > be 64-bit, resulting in UB. > > The issue is caused by the use of "integer_zero_node" where th

[patch] Fix Fortran size_t parameter passing

2019-05-22 Thread Andrew Stubbs
This patch fixes a bug observed on amdgcn in which the Fortran frontend creates function calls using the 32-bit parameters where they ought to be 64-bit, resulting in UB. The issue is caused by the use of "integer_zero_node" where the definition of the function calls for "size_zero_node". I pr