Re: [patch] Expand SJLJ exceptions as tablejump/casesi

2012-09-11 Thread Richard Henderson
On 09/11/2012 10:53 AM, Steven Bosscher wrote: > + force_expand_binop (index_mode, code_to_optab (MINUS), Use sub_optab directly, rather than code_to_optab. Otherwise ok. r~

Re: [patch] Expand SJLJ exceptions as tablejump/casesi

2012-09-11 Thread Steven Bosscher
Hello, Thanks for the quick review! On Tue, Sep 11, 2012 at 5:03 PM, Richard Henderson wrote: > On 09/10/2012 04:26 PM, Steven Bosscher wrote: >> + rtx index = force_reg (index_mode, dispatch_index); > > You can't modify the result of force_reg. Use copy_to_{mode_,}reg instead. Done. >> +

Re: [patch] Expand SJLJ exceptions as tablejump/casesi

2012-09-11 Thread Richard Henderson
On 09/10/2012 04:26 PM, Steven Bosscher wrote: > + rtx index = force_reg (index_mode, dispatch_index); You can't modify the result of force_reg. Use copy_to_{mode_,}reg instead. > + rtx tmp = expand_simple_binop (index_mode, MINUS, > + index, CONST

[patch] Expand SJLJ exceptions as tablejump/casesi

2012-09-10 Thread Steven Bosscher
On Wed, Apr 18, 2012 at 2:44 PM, Richard Henderson wrote: > On 04/18/2012 05:39 AM, Jan Hubicka wrote: >> Well, if SJLJ lowering happens as gimple pass somewhere near the end of >> gimple >> queue, this should not be problem at all. (and implementation would be >> cleaner) > > If you can find a c