Re: [patch] Add support for pragma Loop_Optimize ([No_]Vector)

2014-04-15 Thread Eric Botcazou
> Well, there are passes that can end up duplicating loops and thus you lose > no_vectorize on the copy for example. Clearly that's undesired, no? For > safelen and simduid not copying them is erroring on the safe side at least, > likewise for force_vectorize. But we do have the copy_loop_info a

Re: [patch] Add support for pragma Loop_Optimize ([No_]Vector)

2014-04-15 Thread Richard Biener
On Tue, Apr 15, 2014 at 10:01 AM, Eric Botcazou wrote: >> The loop flags copying should go into copy_loop_info instead of only to >> copy_loops. Jakub - I see you remap simduid on copy - you have to do >> sth in copy_loop_info instead I suppose. See the other callers. > > That also occurred to m

Re: [patch] Add support for pragma Loop_Optimize ([No_]Vector)

2014-04-15 Thread Eric Botcazou
> The loop flags copying should go into copy_loop_info instead of only to > copy_loops. Jakub - I see you remap simduid on copy - you have to do > sth in copy_loop_info instead I suppose. See the other callers. That also occurred to me, but IMO it's not crystal clear; for example, ivdep (aka sa

Re: [patch] Add support for pragma Loop_Optimize ([No_]Vector)

2014-04-15 Thread Richard Biener
On Mon, Apr 14, 2014 at 4:45 PM, Eric Botcazou wrote: > Hi, > > this adds support for 2 optimization hints pertaining to loops in Ada, namely > Loop_Optimize (No_Vector) and Loop_Optimize (Vector), by reusing the Ivdep > approach in the middle-end (ANNOTATE_EXPR node) and directly setting the > do

[patch] Add support for pragma Loop_Optimize ([No_]Vector)

2014-04-14 Thread Eric Botcazou
Hi, this adds support for 2 optimization hints pertaining to loops in Ada, namely Loop_Optimize (No_Vector) and Loop_Optimize (Vector), by reusing the Ivdep approach in the middle-end (ANNOTATE_EXPR node) and directly setting the dont_vectorize and force_vectorize bits of the 'loop' structure.