Re: [patch] Add support for __builtin_bswap128

2020-05-28 Thread H.J. Lu via Gcc-patches
On Thu, May 28, 2020 at 7:30 AM Marek Polacek wrote: > > On Thu, May 28, 2020 at 07:10:20AM -0700, H.J. Lu via Gcc-patches wrote: > > On Wed, May 27, 2020 at 8:26 AM Richard Biener via Gcc-patches > > wrote: > > > > > > On Wed, May 27, 2020 at 3:33 PM Eric Botcazou > > > wrote: > > > > > > > >

Re: [patch] Add support for __builtin_bswap128

2020-05-28 Thread Martin Liška
On 5/28/20 4:30 PM, Marek Polacek via Gcc-patches wrote: On Thu, May 28, 2020 at 07:10:20AM -0700, H.J. Lu via Gcc-patches wrote: On Wed, May 27, 2020 at 8:26 AM Richard Biener via Gcc-patches wrote: On Wed, May 27, 2020 at 3:33 PM Eric Botcazou wrote: Please use int128 effective target r

Re: [patch] Add support for __builtin_bswap128

2020-05-28 Thread Marek Polacek via Gcc-patches
On Thu, May 28, 2020 at 07:10:20AM -0700, H.J. Lu via Gcc-patches wrote: > On Wed, May 27, 2020 at 8:26 AM Richard Biener via Gcc-patches > wrote: > > > > On Wed, May 27, 2020 at 3:33 PM Eric Botcazou wrote: > > > > > > > Please use int128 effective target rather than lp64 in the tests that > >

Re: [patch] Add support for __builtin_bswap128

2020-05-28 Thread H.J. Lu via Gcc-patches
On Wed, May 27, 2020 at 8:26 AM Richard Biener via Gcc-patches wrote: > > On Wed, May 27, 2020 at 3:33 PM Eric Botcazou wrote: > > > > > Please use int128 effective target rather than lp64 in the tests that need > > > __int128 type. > > > > OK, thanks, adjusted locally. > > OK. I am checking in

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Richard Biener via Gcc-patches
On Wed, May 27, 2020 at 3:33 PM Eric Botcazou wrote: > > > Please use int128 effective target rather than lp64 in the tests that need > > __int128 type. > > OK, thanks, adjusted locally. OK. Thanks, Richard. > -- > Eric Botcazou

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Eric Botcazou
> Please use int128 effective target rather than lp64 in the tests that need > __int128 type. OK, thanks, adjusted locally. -- Eric Botcazou

Re: [patch] Add support for __builtin_bswap128

2020-05-27 Thread Jakub Jelinek via Gcc-patches
On Wed, May 27, 2020 at 11:23:32AM +0200, Eric Botcazou wrote: > gcc/testsuite/ChangeLog: > > * gcc.dg/builtin-bswap-10.c: New test. > * gcc.dg/builtin-bswap-11.c: Likewise. > * gcc.dg/builtin-bswap-12.c: Likewise. > * gcc.target/i386/builtin-bswap-5.c: Likewise. Please us

[patch] Add support for __builtin_bswap128

2020-05-27 Thread Eric Botcazou
Hi, this patch introduces a new builtin named __builtin_bswap128 on targets where TImode is supported, i.e. 64-bit targets only in practice. The implementation simply reuses the existing double word path in optab, so no routine is added to libgcc (which means that you get two calls to _bswapdi