Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Richard Guenther
On Fri, Jul 13, 2012 at 11:41 AM, Dehao Chen wrote: > On Fri, Jul 13, 2012 at 3:36 PM, Richard Guenther > wrote: >> >> On Fri, Jul 13, 2012 at 9:18 AM, Steven Bosscher >> wrote: >> > On Fri, Jul 13, 2012 at 3:36 AM, Dehao Chen wrote: >> >> I'd suggest: >> >> 1. Remove this unittest for now. >>

Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Dehao Chen
On Fri, Jul 13, 2012 at 3:36 PM, Richard Guenther wrote: > > On Fri, Jul 13, 2012 at 9:18 AM, Steven Bosscher > wrote: > > On Fri, Jul 13, 2012 at 3:36 AM, Dehao Chen wrote: > >> I'd suggest: > >> 1. Remove this unittest for now. > > > > And revert the patch for now. > > > > > >> 2. Integrate l

Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Richard Guenther
On Fri, Jul 13, 2012 at 9:50 AM, Steven Bosscher wrote: > On Fri, Jul 13, 2012 at 9:36 AM, Richard Guenther > wrote: >> Btw, we discussed this briefly on the summit with Dodji and libcpp >> virtual locations already provide a way to associate a location_t with >> something else resulting in a new

Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Steven Bosscher
On Fri, Jul 13, 2012 at 9:36 AM, Richard Guenther wrote: > Btw, we discussed this briefly on the summit with Dodji and libcpp > virtual locations already provide a way to associate a location_t with > something else resulting in a new location_t. For inlining we simply have > to say that the loca

Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Richard Guenther
On Fri, Jul 13, 2012 at 9:18 AM, Steven Bosscher wrote: > On Fri, Jul 13, 2012 at 3:36 AM, Dehao Chen wrote: >> I'd suggest: >> 1. Remove this unittest for now. > > And revert the patch for now. > > >> 2. Integrate locus with block, and store them as an index. (This will >> incur big operation to

Re: [patch] Add block debug info to phi_arg_d

2012-07-13 Thread Steven Bosscher
On Fri, Jul 13, 2012 at 3:36 AM, Dehao Chen wrote: > I'd suggest: > 1. Remove this unittest for now. And revert the patch for now. > 2. Integrate locus with block, and store them as an index. (This will > incur big operation to GCC) I'm not sure what you mean with "integrate"...? A lot of the

Re: [patch] Add block debug info to phi_arg_d

2012-07-12 Thread Dehao Chen
This implies: 1. This patch does not fix the inline stack issue completely, because expression still does not carry block info correctly. 2. It's not easily possible to check the correctness of the inline stack info by grepping the assembly. I'd suggest: 1. Remove this unittest for now. 2. Integr

Re: [patch] Add block debug info to phi_arg_d

2012-07-12 Thread Uros Bizjak
Hello! > A test is added. Is it ok? > > gcc/testsuite/ChangeLog > > 2012-07-08 Dehao Chen > > * gcc.dg/debug_info_inline.c: New test. This test fails on alphaev68-unknown-linux-gnu [1] and other non-x86 targets [2] too: FAIL: gcc.dg/debug_info_inline.c scan-assembler loc 1 19 0\\n.*\\

Re: [patch] Add block debug info to phi_arg_d

2012-07-09 Thread Richard Guenther
On Sun, Jul 8, 2012 at 9:29 AM, Dehao Chen wrote: > Hi, Richard, > > A test is added. Is it ok? Ok. Thanks, RIchard. > Thanks, > Dehao > > gcc/testsuite/ChangeLog > > 2012-07-08 Dehao Chen > > * gcc.dg/debug_info_inline.c: New test. > > Index: gcc/testsuite/gcc.dg/debug_info_inline.c

Re: [patch] Add block debug info to phi_arg_d

2012-07-08 Thread Dehao Chen
Hi, Richard, A test is added. Is it ok? Thanks, Dehao gcc/testsuite/ChangeLog 2012-07-08 Dehao Chen * gcc.dg/debug_info_inline.c: New test. Index: gcc/testsuite/gcc.dg/debug_info_inline.c === --- gcc/testsuite/gcc.dg/d

Re: [patch] Add block debug info to phi_arg_d

2012-07-05 Thread Richard Guenther
On Thu, Jul 5, 2012 at 12:15 PM, Dehao Chen wrote: > > On Thu, Jul 5, 2012 at 5:58 PM, Richard Guenther > wrote: >> >> On Thu, Jul 5, 2012 at 11:42 AM, Steven Bosscher >> wrote: >> > On Thu, Jul 5, 2012 at 11:23 AM, Richard Guenther >> > wrote: >> >> On Thu, Jul 5, 2012 at 11:08 AM, Dehao Chen

Re: [patch] Add block debug info to phi_arg_d

2012-07-05 Thread Dehao Chen
On Thu, Jul 5, 2012 at 5:58 PM, Richard Guenther wrote: > > On Thu, Jul 5, 2012 at 11:42 AM, Steven Bosscher > wrote: > > On Thu, Jul 5, 2012 at 11:23 AM, Richard Guenther > > wrote: > >> On Thu, Jul 5, 2012 at 11:08 AM, Dehao Chen wrote: > >>> Hi, > >>> > >>> This patch added block field to p

Re: [patch] Add block debug info to phi_arg_d

2012-07-05 Thread Richard Guenther
On Thu, Jul 5, 2012 at 11:42 AM, Steven Bosscher wrote: > On Thu, Jul 5, 2012 at 11:23 AM, Richard Guenther > wrote: >> On Thu, Jul 5, 2012 at 11:08 AM, Dehao Chen wrote: >>> Hi, >>> >>> This patch added block field to phi_arg_d to make sure the associated >>> source locus is consistent with its

Re: [patch] Add block debug info to phi_arg_d

2012-07-05 Thread Steven Bosscher
On Thu, Jul 5, 2012 at 11:23 AM, Richard Guenther wrote: > On Thu, Jul 5, 2012 at 11:08 AM, Dehao Chen wrote: >> Hi, >> >> This patch added block field to phi_arg_d to make sure the associated >> source locus is consistent with its block info. >> >> Bootstrapped and passed gcc regression tests. >