On 19/08/13 09:00, Jonathan Wakely wrote:
> On 16 August 2013 16:28, Tom Tromey wrote:
>>> "Phil" == Phil Muldoon writes:
>>
>> Phil> Anyway, I have regenerated the patch with the fixes requested.
>>
>> Thanks.
>>
>> Phil> 2013-08-16 Phil Muldoon
>>
>> Phil> PR gcc/53477
>>
>> I think thi
On 16 August 2013 16:28, Tom Tromey wrote:
>> "Phil" == Phil Muldoon writes:
>
> Phil> Anyway, I have regenerated the patch with the fixes requested.
>
> Thanks.
>
> Phil> 2013-08-16 Phil Muldoon
>
> Phil> PR gcc/53477
>
> I think this should say PR libstdc++/53477
>
> Other than this ni
> "Phil" == Phil Muldoon writes:
Phil> Anyway, I have regenerated the patch with the fixes requested.
Thanks.
Phil> 2013-08-16 Phil Muldoon
Phil> PR gcc/53477
I think this should say PR libstdc++/53477
Other than this nit, it looks good to me.
I can't remember if I can approve thes
On 23/07/13 15:23, Tom Tromey wrote:
>> "Phil" == Phil Muldoon writes:
>
> Phil> On 03/07/13 08:33, Phil Muldoon wrote:
>>> This new patch replaces and obsoletes the previous. On further
>>> inspection of some other pretty printer related bugs, it seems that
>>> all of the printers need to f
> "Phil" == Phil Muldoon writes:
Phil> On 03/07/13 08:33, Phil Muldoon wrote:
>> This new patch replaces and obsoletes the previous. On further
>> inspection of some other pretty printer related bugs, it seems that
>> all of the printers need to fetch the referenced value where the value
>>
On 03/07/13 08:33, Phil Muldoon wrote:
> This new patch replaces and obsoletes the previous. On further
> inspection of some other pretty printer related bugs, it seems that
> all of the printers need to fetch the referenced value where the value
> type is a reference. This patch applies that ch
> "Phil" == Phil Muldoon writes:
Phil> 2013-07-03 Phil Muldoon
Phil> PR gcc/53477
Phil> http://sourceware.org/bugzilla/show_bug.cgi?id=15195
Phil> * python/libstdcxx/v6/printers.py (Printer.__call__): If a value
Phil> is a reference, fetch referenced value.
Phil> (RxPrinter.invok
On 13/06/13 14:49, Tom Tromey wrote:
>> "Phil" == Phil Muldoon writes:
>
> Phil> Attached is an updated patch correcting the issues that you pointed
> Phil> out.
>
> The patch itself looks fine to me, but I don't think I can approve it.
>
> Tom
This new patch replaces and obsoletes the pre
> "Phil" == Phil Muldoon writes:
Phil> Attached is an updated patch correcting the issues that you pointed
Phil> out.
The patch itself looks fine to me, but I don't think I can approve it.
Tom
On 21/03/13 14:20, Tom Tromey wrote:
>> "Phil" == Phil Muldoon writes:
>
> Phil> 2013-03-21 Phil Muldoon
> Phil> PR gdb/15195
>
> I think this should use a full URL.
> Phil> def to_string (self):
>
> Why doesn't the 'children' method also need a fix?
>
> Also, Phil and I d
> "Phil" == Phil Muldoon writes:
Phil> 2013-03-21 Phil Muldoon
Phil> PR gdb/15195
I think this should use a full URL.
Otherwise it is going to attach the commit to some random GCC bug.
Phil> * python/libstdcxx/v6/printers.py (StdTuplePrinter): Convert
Phil> referenced value to actu
This patch fixes a bug in the std::tuple printer where, if the value
was passed by reference, the printer was not correctly dereferencing the
value before printing.
Cheers,
Phil
2013-03-21 Phil Muldoon
PR gdb/15195
* python/libstdcxx/v6/printers.py (StdTuplePrinter): Conve
12 matches
Mail list logo
