Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Iain Sandoe
On 22 Mar 2012, at 00:00, Steven Bosscher wrote: On Thu, Mar 22, 2012 at 12:53 AM, Iain Sandoe wrote: conceptually, the issue is that there are multiple sets of built-ins (potentially, one set for each runtime, and the sets are of different sizes). Thus, it's not just a case of turning thes

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Steven Bosscher
On Thu, Mar 22, 2012 at 12:53 AM, Iain Sandoe wrote: > conceptually, the issue is that there are multiple sets of built-ins > (potentially, one set for each runtime, and the sets are of different > sizes).  Thus, it's not just a case of turning these into regular built-ins, > without some mechani

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Iain Sandoe
On 21 Mar 2012, at 22:45, Steven Bosscher wrote: On Wed, Mar 21, 2012 at 11:11 PM, Mike Stump wrote: On Mar 21, 2012, at 2:32 PM, Steven Bosscher wrote: In any case, if there's nothing left to fix for PR24777, I suppose it can be closed as FIXED. I see all sorts of FIXME: in c-decl.c st

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Steven Bosscher
On Wed, Mar 21, 2012 at 11:11 PM, Mike Stump wrote: > On Mar 21, 2012, at 2:32 PM, Steven Bosscher wrote: >> In any case, if there's nothing left to fix for PR24777, I suppose it >> can be closed as FIXED. > > I see all sorts of FIXME: in c-decl.c still...  Anyway, someone needs to sort > out wha

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Mike Stump
On Mar 21, 2012, at 2:32 PM, Steven Bosscher wrote: > In any case, if there's nothing left to fix for PR24777, I suppose it > can be closed as FIXED. I see all sorts of FIXME: in c-decl.c still... Anyway, someone needs to sort out what is done and remains undone and update the FIXMEs... I don't

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Mike Stump
On Mar 21, 2012, at 2:09 PM, Steven Bosscher wrote: > There is no reason for the ObjC front end to call assemble_external on > these symbols, > OK for trunk? Ok. Watch for hate mail from Jack, if you guess wrong. :-)

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Steven Bosscher
On Wed, Mar 21, 2012 at 10:23 PM, Iain Sandoe wrote: >> objc/ >>        * objc-act (objc_build_ivar_assignment): Do not call >> assemble_external. >>        (objc_build_global_assignment): Likewise. >>        (objc_build_strong_cast_assignment): Likewise. >>        * objc-next-runtime-abi-01.c: Cl

Re: [patch][objc] Do not call assemble_external

2012-03-21 Thread Iain Sandoe
Hi Steven, On 21 Mar 2012, at 21:09, Steven Bosscher wrote: There is no reason for the ObjC front end to call assemble_external on these symbols, the middle-end handles this just fine via add_builtin_function. Ah, that's the bit I'd yet to figure out ... Bootstrapped&tested on powerpc64-unkn

[patch][objc] Do not call assemble_external

2012-03-21 Thread Steven Bosscher
Hello, There is no reason for the ObjC front end to call assemble_external on these symbols, the middle-end handles this just fine via add_builtin_function. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Ciao! Steven objc/ * objc-act (objc_build_ivar_assignment): Do n