Re: [patch][RFC] Remove tree/gimple/rtl dependencies from core CFG code

2012-07-07 Thread Joseph S. Myers
On Sat, 7 Jul 2012, Steven Bosscher wrote: > BTW, why do so many libgcc files include coretypes.h? It might be needed for the tm.h includes, if tm.h uses types from coretypes.h - there are still a fair number of host-side tm.h macros used in libgcc, that need to transition to libgcc-only target

Re: [patch][RFC] Remove tree/gimple/rtl dependencies from core CFG code

2012-07-07 Thread Steven Bosscher
On Fri, Jul 6, 2012 at 8:29 AM, Steven Bosscher wrote: > On Fri, Jul 6, 2012 at 1:06 AM, Joseph S. Myers > wrote: >> My only comment is that you add a coretypes.h include to tree-flow.h and >> remove one from tree-ssa-alias.h - but since the GCC convention is that >> all .c files start with incl

Re: [patch][RFC] Remove tree/gimple/rtl dependencies from core CFG code

2012-07-06 Thread Richard Guenther
On Thu, Jul 5, 2012 at 11:53 PM, Steven Bosscher wrote: > Hello, > > This is a first stab at making the core CFG code independent of the > expression intermediate representation datatypes. This patch deals > with cfg.c and cfganal.c but it shouldn't be a surprise that the patch > touches a lot of

Re: [patch][RFC] Remove tree/gimple/rtl dependencies from core CFG code

2012-07-05 Thread Steven Bosscher
On Fri, Jul 6, 2012 at 1:06 AM, Joseph S. Myers wrote: > My only comment is that you add a coretypes.h include to tree-flow.h and > remove one from tree-ssa-alias.h - but since the GCC convention is that > all .c files start with includes of config.h, system.h and coretypes.h in > that order, the

Re: [patch][RFC] Remove tree/gimple/rtl dependencies from core CFG code

2012-07-05 Thread Joseph S. Myers
My only comment is that you add a coretypes.h include to tree-flow.h and remove one from tree-ssa-alias.h - but since the GCC convention is that all .c files start with includes of config.h, system.h and coretypes.h in that order, the include in tree-flow.h shouldn't be needed - any source file