Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Steven Bosscher
On Fri, Oct 12, 2012 at 3:31 PM, Vladimir Makarov wrote: > Ops. Sorry, Steven. I did a wrong conclusion because I thought I would > have found such code generation problem if it had an affect. Oh, the patch shouldn't (and doesn't) change the generated code, that is not how cfgloops works: record

Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Richard Biener
On Fri, 12 Oct 2012, Vladimir Makarov wrote: > On 12-10-12 4:56 AM, Richard Biener wrote: > > On Fri, 12 Oct 2012, Steven Bosscher wrote: > > > > > On Fri, Oct 12, 2012 at 6:16 AM, Vladimir Makarov wrote: > > > > On 12-10-11 4:17 PM, Steven Bosscher wrote: > > > > > Hello, > > > > > > > > > > IR

Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Vladimir Makarov
On 12-10-12 4:56 AM, Richard Biener wrote: On Fri, 12 Oct 2012, Steven Bosscher wrote: On Fri, Oct 12, 2012 at 6:16 AM, Vladimir Makarov wrote: On 12-10-11 4:17 PM, Steven Bosscher wrote: Hello, IRA uses record_loop_exits() to cache the loop exit edges, but due to a code ordering bug the edg

Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Vladimir Makarov
On 12-10-12 4:12 AM, Steven Bosscher wrote: On Fri, Oct 12, 2012 at 6:16 AM, Vladimir Makarov wrote: On 12-10-11 4:17 PM, Steven Bosscher wrote: Hello, IRA uses record_loop_exits() to cache the loop exit edges, but due to a code ordering bug the edges are not actually recorded. record_loop_exi

Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Richard Biener
On Fri, 12 Oct 2012, Steven Bosscher wrote: > On Fri, Oct 12, 2012 at 6:16 AM, Vladimir Makarov wrote: > > On 12-10-11 4:17 PM, Steven Bosscher wrote: > >> > >> Hello, > >> > >> IRA uses record_loop_exits() to cache the loop exit edges, but due to > >> a code ordering bug the edges are not actuall

Re: [patch][IRA] Really record loop exits

2012-10-12 Thread Steven Bosscher
On Fri, Oct 12, 2012 at 6:16 AM, Vladimir Makarov wrote: > On 12-10-11 4:17 PM, Steven Bosscher wrote: >> >> Hello, >> >> IRA uses record_loop_exits() to cache the loop exit edges, but due to >> a code ordering bug the edges are not actually recorded. >> record_loop_exits() starts with: >> >>if

Re: [patch][IRA] Really record loop exits

2012-10-11 Thread Vladimir Makarov
On 12-10-11 4:17 PM, Steven Bosscher wrote: Hello, IRA uses record_loop_exits() to cache the loop exit edges, but due to a code ordering bug the edges are not actually recorded. record_loop_exits() starts with: if (!current_loops) return; I have no idea why record_loop_exits is here. L

[patch][IRA] Really record loop exits

2012-10-11 Thread Steven Bosscher
Hello, IRA uses record_loop_exits() to cache the loop exit edges, but due to a code ordering bug the edges are not actually recorded. record_loop_exits() starts with: if (!current_loops) return; So ira.c should set current_loops before calling record_loop_exits. With the current order, the