Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-28 Thread Richard Biener
On Tue, Aug 27, 2024 at 7:53 PM Georg-Johann Lay wrote: > > Am 27.08.24 um 17:28 schrieb Jeff Law: > > > > On 8/26/24 1:15 PM, Georg-Johann Lay wrote: > > > >> What the avr-ifelse pass does is try to replace 2 cbranch insns with > >> one compare insn and two branches. It runs after reload and jus

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-27 Thread Georg-Johann Lay
Am 27.08.24 um 17:28 schrieb Jeff Law: On 8/26/24 1:15 PM, Georg-Johann Lay wrote: What the avr-ifelse pass does is try to replace 2 cbranch insns with one compare insn and two branches.  It runs after reload and just prior to .split2 (split_after_reload).  It must run after reload because REG

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-27 Thread Jeff Law
On 8/26/24 1:15 PM, Georg-Johann Lay wrote: What the avr-ifelse pass does is try to replace 2 cbranch insns with one compare insn and two branches.  It runs after reload and just prior to .split2 (split_after_reload).  It must run after reload because REG_CC comes into existence in .split2. 

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-26 Thread Georg-Johann Lay
Am 25.08.24 um 18:15 schrieb Denis Chertykov: Starting to review the patch... Denis Great to see you back! Prior to commenting on the attached new versions of the overhaul, let me answer Jeff's questions from the other mail: On 8/23/24 6:16 AM, Georg-Johann Lay wrote: This patch overhauls

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-26 Thread Denis Chertykov
вс, 25 авг. 2024 г. в 20:15, Denis Chertykov : > > > > вс, 25 авг. 2024 г. в 17:55, Jeff Law : >> >> >> >> On 8/23/24 6:20 AM, Richard Biener wrote: >> > On Fri, Aug 23, 2024 at 2:16 PM Georg-Johann Lay wrote: >> >> >> >> This patch overhauls the avr-ifelse mini-pass that optimizes >> >> two cbran

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-25 Thread Denis Chertykov
вс, 25 авг. 2024 г. в 17:55, Jeff Law : > > > On 8/23/24 6:20 AM, Richard Biener wrote: > > On Fri, Aug 23, 2024 at 2:16 PM Georg-Johann Lay wrote: > >> > >> This patch overhauls the avr-ifelse mini-pass that optimizes > >> two cbranch insns to one comparison and two branches. > >> > >> More opti

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-25 Thread Jeff Law
On 8/23/24 6:16 AM, Georg-Johann Lay wrote: This patch overhauls the avr-ifelse mini-pass that optimizes two cbranch insns to one comparison and two branches. More optimization opportunities are realized, and the code has been refactored. No new regressions.  Ok for trunk? There is currentl

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-25 Thread Jeff Law
On 8/23/24 6:20 AM, Richard Biener wrote: On Fri, Aug 23, 2024 at 2:16 PM Georg-Johann Lay wrote: This patch overhauls the avr-ifelse mini-pass that optimizes two cbranch insns to one comparison and two branches. More optimization opportunities are realized, and the code has been refactore

Re: [patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-23 Thread Richard Biener
On Fri, Aug 23, 2024 at 2:16 PM Georg-Johann Lay wrote: > > This patch overhauls the avr-ifelse mini-pass that optimizes > two cbranch insns to one comparison and two branches. > > More optimization opportunities are realized, and the code > has been refactored. > > No new regressions. Ok for tru

[patch,avr] Overhaul avr-ifelse RTL optimization pass

2024-08-23 Thread Georg-Johann Lay
This patch overhauls the avr-ifelse mini-pass that optimizes two cbranch insns to one comparison and two branches. More optimization opportunities are realized, and the code has been refactored. No new regressions. Ok for trunk? There is currently no avr maintainer, so some global reviewer mig