Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Jakub Jelinek
On Fri, Jul 05, 2019 at 03:40:55PM +0100, Andrew Stubbs wrote: > On 05/07/2019 15:04, Jakub Jelinek wrote: > > > For OpenMP, a warning is not good enough, because if Fortran PARAMETER is > > > not a variable, then the program is invalid and needs to be rejected. > > > You could improve the diagnost

Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Andrew Stubbs
On 05/07/2019 15:04, Jakub Jelinek wrote: For OpenMP, a warning is not good enough, because if Fortran PARAMETER is not a variable, then the program is invalid and needs to be rejected. You could improve the diagnostics by adding some explanation message that fortran PARAMETER is not a variable.

Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Jakub Jelinek
On Fri, Jul 05, 2019 at 02:15:12PM +0200, Jakub Jelinek wrote: > On Fri, Jul 05, 2019 at 01:10:00PM +0100, Andrew Stubbs wrote: > > > so I don't believe Fortran parameters are OpenMP variables. > > > Scalar Fortran parameters don't even have any data storage block > > > associated > > > with them

Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Jakub Jelinek
On Fri, Jul 05, 2019 at 01:10:00PM +0100, Andrew Stubbs wrote: > > so I don't believe Fortran parameters are OpenMP variables. > > Scalar Fortran parameters don't even have any data storage block associated > > with them at all. > > Agreed, they are not variables (nor variable), and copying them a

Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Andrew Stubbs
On 05/07/2019 12:49, Jakub Jelinek wrote: On Fri, Jul 05, 2019 at 12:31:17PM +0100, Andrew Stubbs wrote: This patch allows Fortran "parameter" named constants to be named in OpenMP map and OpenACC copy directives. Right now, the compiler just says something like: !$omp target data map(to

Re: [patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Jakub Jelinek
On Fri, Jul 05, 2019 at 12:31:17PM +0100, Andrew Stubbs wrote: > This patch allows Fortran "parameter" named constants to be named in OpenMP > map and OpenACC copy directives. > > Right now, the compiler just says something like: > > !$omp target data map(tofrom:N,x) >

[patch, openmp/openacc] Allow Fortran parameters in map/copy.

2019-07-05 Thread Andrew Stubbs
This patch allows Fortran "parameter" named constants to be named in OpenMP map and OpenACC copy directives. Right now, the compiler just says something like: !$omp target data map(tofrom:N,x) 1 Error: Object 'n' is not a variable at (1) This is technica