Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-07 Thread Sandra Loosemore
On 06/06/2014 01:44 AM, Richard Biener wrote: On Fri, 6 Jun 2014, Richard Sandiford wrote: [snip] How about initialising the DECL_ALIGN to: (TARGET_PTRMEMFUNC_VBIT_LOCATION == ptrmemfunc_vbit_in_pfn ? 2 * BITS_PER_UNIT : BITS_PER_UNIT) instead of function_boundary (NULL)? That wa

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-06 Thread Richard Biener
On Fri, 6 Jun 2014, Richard Sandiford wrote: > Richard Biener writes: > > On Thu, 5 Jun 2014, Sandra Loosemore wrote: > > > >> On 06/05/2014 03:50 PM, Richard Sandiford wrote: > >> > Sandra Loosemore writes: > >> > > On 06/05/2014 01:39 AM, Richard Biener wrote: > >> > > > > >> > > > [snip] > >

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-06 Thread Richard Sandiford
Richard Biener writes: > On Thu, 5 Jun 2014, Sandra Loosemore wrote: > >> On 06/05/2014 03:50 PM, Richard Sandiford wrote: >> > Sandra Loosemore writes: >> > > On 06/05/2014 01:39 AM, Richard Biener wrote: >> > > > >> > > > [snip] >> > > > >> > > > Ok, we definitely need to preserve that (docum

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-06 Thread Richard Biener
On Thu, 5 Jun 2014, Sandra Loosemore wrote: > On 06/05/2014 03:50 PM, Richard Sandiford wrote: > > Sandra Loosemore writes: > > > On 06/05/2014 01:39 AM, Richard Biener wrote: > > > > > > > > [snip] > > > > > > > > Ok, we definitely need to preserve that (documented) behavior. I > > > > suppos

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-05 Thread Sandra Loosemore
On 06/05/2014 03:50 PM, Richard Sandiford wrote: Sandra Loosemore writes: On 06/05/2014 01:39 AM, Richard Biener wrote: [snip] Ok, we definitely need to preserve that (documented) behavior. I suppose it also sets DECL_USER_ALIGN. -falign-functions is probably another setter of DECL_ALIGN h

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-05 Thread Richard Sandiford
Sandra Loosemore writes: > On 06/05/2014 01:39 AM, Richard Biener wrote: >> >> [snip] >> >> Ok, we definitely need to preserve that (documented) behavior. I suppose >> it also sets DECL_USER_ALIGN. -falign-functions is probably another >> setter of DECL_ALIGN here. >> >> If we add a target hook

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-05 Thread Sandra Loosemore
On 06/05/2014 01:39 AM, Richard Biener wrote: [snip] Ok, we definitely need to preserve that (documented) behavior. I suppose it also sets DECL_USER_ALIGN. -falign-functions is probably another setter of DECL_ALIGN here. If we add a target hook that may adjust function alignment then it has

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-05 Thread Richard Biener
On Wed, 4 Jun 2014, Sandra Loosemore wrote: > On 06/04/2014 06:20 AM, Richard Biener wrote: > > On Tue, 3 Jun 2014, Richard Sandiford wrote: > > > > > Richi suggested just changing the alignment at output time. I assume > > > that would be a case of replacing the DECL_ALIGN in: > > > > > >/

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-04 Thread Sandra Loosemore
On 06/04/2014 06:20 AM, Richard Biener wrote: On Tue, 3 Jun 2014, Richard Sandiford wrote: Richi suggested just changing the alignment at output time. I assume that would be a case of replacing the DECL_ALIGN in: /* Tell assembler to move to target machine's alignment for functions. */

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-04 Thread Richard Biener
On Tue, 3 Jun 2014, Richard Sandiford wrote: > Sandra Loosemore writes: > > Catherine included an earlier version of this patch with the microMIPS > > submission a couple years ago: > > > > https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html > > > > Richard's response was: > > > >> Looks li

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-06-03 Thread Richard Sandiford
Sandra Loosemore writes: > Catherine included an earlier version of this patch with the microMIPS > submission a couple years ago: > > https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html > > Richard's response was: > >> Looks like the wrong place to do this. Please treat this as a separate

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-31 Thread Richard Sandiford
Sandra Loosemore writes: > On 05/28/2014 01:09 PM, Richard Sandiford wrote: >> Sandra Loosemore writes: >> >>> On 05/19/2014 01:38 PM, Sandra Loosemore wrote: 2014-05-19 Iain Sandoe Catherine Moore Sandra Loosemore gcc/ * c

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-30 Thread Sandra Loosemore
On 05/28/2014 01:09 PM, Richard Sandiford wrote: Sandra Loosemore writes: On 05/19/2014 01:38 PM, Sandra Loosemore wrote: 2014-05-19 Iain Sandoe Catherine Moore Sandra Loosemore gcc/ * config/mips/mips.c (mips_set_current_function): Choose functi

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-28 Thread Richard Sandiford
Sandra Loosemore writes: > On 05/19/2014 01:38 PM, Sandra Loosemore wrote: >> >> 2014-05-19 Iain Sandoe >> Catherine Moore >> Sandra Loosemore >> >> gcc/ >> * config/mips/mips.c (mips_set_current_function): Choose >> function alignment once the current mode

Re: [patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-28 Thread Sandra Loosemore
On 05/19/2014 01:38 PM, Sandra Loosemore wrote: 2014-05-19 Iain Sandoe Catherine Moore Sandra Loosemore gcc/ * config/mips/mips.c (mips_set_current_function): Choose function alignment once the current mode is known. gcc/testsuite/ * gcc.target

[patch, mips, tree] align microMIPS functions to 16 bits with -Os

2014-05-19 Thread Sandra Loosemore
Catherine included an earlier version of this patch with the microMIPS submission a couple years ago: https://gcc.gnu.org/ml/gcc-patches/2012-07/msg00972.html Richard's response was: Looks like the wrong place to do this. Please treat this as a separate patch and get a tree expert to comment