Re: [patch, libiberty] avoid closing files twice on Windows when exec fails

2012-07-26 Thread DJ Delorie
I wonder if registering a handler for invalid parameters, at least around those calls, so that we can enforce the posix-like "return an error" semantics? > OK for mainline? Ok. > 2012-07-26 Kazu Hirata > Sandra Loosemore > > libiberty/ > * pex-win32.c (pex_win32_exec

[patch, libiberty] avoid closing files twice on Windows when exec fails

2012-07-26 Thread Sandra Loosemore
This is a libiberty patch for Windows that we've had in our local tree for a couple of years now. The problem it addresses showed up in Windows-hosted GDB; we were getting a crash inside _close() in the case where creation of the child process has failed. Apparently Windows gets very unhappy