Hi Steven,
Ping?
I would like to start committing patches so I don't have too many
of them in my tree at the same time :-)
This looks OK to me.
Committed as rev. 192158. I'll commit to 4.7 and after that to 4.6
in a few days.
Thanks a lot for the review!
Thomas
On Sat, Oct 6, 2012 at 1:31 PM, Thomas Koenig wrote:
> Am 01.10.2012 20:34, schrieb Thomas Koenig:
>>
>> Hello world,
>>
>> the previous version of the patch has an issue that Shane pointed
>> out in the PR. This version should work; at least it survived
>> all the test cases I could come up with
Am 01.10.2012 20:34, schrieb Thomas Koenig:
Hello world,
the previous version of the patch has an issue that Shane pointed
out in the PR. This version should work; at least it survived
all the test cases I could come up with.
Regression-tested (again). OK for trunk? Also for 4.6 and 4.7?
P
Hello world,
the previous version of the patch has an issue that Shane pointed
out in the PR. This version should work; at least it survived
all the test cases I could come up with.
Regression-tested (again). OK for trunk? Also for 4.6 and 4.7?
Thomas
2012-10-01 Thomas König
Hello world,
the attached patch fixes the PR. The logic for processing
GFORTRAN_CONVERT_UNIT had been quite wrong. I have checked
that the original test case, plus a few more, no longer cause
assertion failures or memory corruption (also checked with
valgrind). No test case because it is not p
