[patch, libfortran, committed] Suppress -Wstringop-overflow warning

2020-06-13 Thread Thomas Koenig via Gcc-patches
Hi, I just committed as obvious the patch below. Disable -Wstringop-overflow warning after checking code path of caller. The warning that is disabled, only on this single line, has been inspected and found to be not applicable; it is known that the size of the buffer is safe. libgfortran/Chang

[patch, libfortran, committed]

2020-05-14 Thread Thomas Koenig via Gcc-patches
Hi, I just committed as obvious a patch which fixed a hang on close with -pthread after a previous error on close with an invalid STATUS. The solution was obvious: Return early if an error occurred. I also managed to make some double ChangeLog entries (fixed with the next commit after), but hey

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-25 Thread Martin Jambor
Hi, On Thu, Apr 19 2018, Thomas Schwinge wrote: > > Per PR85463 '[nvptx] "exit" in offloaded region doesn't terminate > process' that I just filed, we currently have to use "abort" instead of > "exit" for nvptx offloading, so I have applied the following in trunk > r259491, where I completed this

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Thomas Schwinge
Hi! On Thu, 19 Apr 2018 13:32:16 +0200, Thomas König wrote: > > Mapping exit to abort is weird, > > For Fortran, this is mapping STOP with a numeric code to abort. > > The Fortran standard does not apply in this case. What does the OpenACC > standard say about STOP in an offloaded region? Noth

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Thomas König
> Mapping exit to abort is weird, For Fortran, this is mapping STOP with a numeric code to abort. The Fortran standard does not apply in this case. What does the OpenACC standard say about STOP in an offloaded region? Regards, Thomas

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Thomas Schwinge
Hi! On Thu, 19 Apr 2018 11:25:30 +0200, Jakub Jelinek wrote: > On Thu, Apr 19, 2018 at 11:19:31AM +0200, Thomas Schwinge wrote: > > On Thu, 19 Apr 2018 11:14:38 +0200, Jakub Jelinek wrote: > > > On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote: > > > > On Wed, 4 Apr 2018 11:30:34

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Jakub Jelinek
On Thu, Apr 19, 2018 at 11:19:31AM +0200, Thomas Schwinge wrote: > Hi! > > On Thu, 19 Apr 2018 11:14:38 +0200, Jakub Jelinek wrote: > > On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote: > > > On Wed, 4 Apr 2018 11:30:34 +0200, Thomas König wrote: > > > > the recent patch to make t

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Thomas Schwinge
Hi! On Thu, 19 Apr 2018 11:14:38 +0200, Jakub Jelinek wrote: > On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote: > > On Wed, 4 Apr 2018 11:30:34 +0200, Thomas König wrote: > > > the recent patch to make the gfortran and libgomp testsuites more > > > standard conforming, by replaci

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Jakub Jelinek
On Thu, Apr 19, 2018 at 11:06:18AM +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 4 Apr 2018 11:30:34 +0200, Thomas König wrote: > > the recent patch to make the gfortran and libgomp testsuites more > > standard conforming, by replacing CALL ABORT() with STOP N, led > > to numerous testsuite fai

PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

2018-04-19 Thread Thomas Schwinge
Hi! On Wed, 4 Apr 2018 11:30:34 +0200, Thomas König wrote: > the recent patch to make the gfortran and libgomp testsuites more > standard conforming, by replacing CALL ABORT() with STOP N, led > to numerous testsuite failures on nvptx because stop_numeric > was not implemented in minimal.c. > >

[patch, libfortran, committed] Implement stop_numeric for minimal targets

2018-04-04 Thread Thomas König
Hello world, the recent patch to make the gfortran and libgomp testsuites more standard conforming, by replacing CALL ABORT() with STOP N, led to numerous testsuite failures on nvptx because stop_numeric was not implemented in minimal.c. I have committed the patch below in r259072 as obvious aft

[patch, libfortran, committed] Restore bootstrap on non-x86* systems

2017-05-26 Thread Thomas Koenig
Hello world, I have committed the attached patch as obvious as r248519 after testing that it does indeed work on powerpc64-unknown-linux-gnu and that it passes regression-test on that machine. Sorry for the breakage. I'll use the gcc compile farm machines in the future to test any such changes.

[PATCH, libfortran]: Committed: Read rounding mode from SSE mxcsr register on x86_64.

2013-07-23 Thread Uros Bizjak
Hello! On x86_64, we can look into SSE mxcsr register to determine rounding mode. 2013-07-23 Uros Bizjak * config/fpu-387.h (get_fpu_rounding_mode): Read rounding mode from SSE mxcsr register on x86_64. Tested on x86_64-pc-linux-gnu {,-m32} and committed to mainline svn. BTW. gfor

[Patch, libfortran, committed] Remove configure check for unused fdopen function

2012-01-12 Thread Janne Blomqvist
Committed the patch below as obvious. 2012-01-12 Janne Blomqvist * configure.ac: Remove check for fdopen. * runtime/backtrace.c (CAN_PIPE): Fix comment, remove check for fdopen. * configure: Regenerated. * config.h.in: Regenerated. Index: configure.ac

[Patch, libfortran, committed] Cleanup NEWUNIT allocation

2011-11-01 Thread Janne Blomqvist
Hi, attached patch committed to trunk as obvious after regtesting. 2011-11-01 Janne Blomqvist * io/io.h (next_available_newunit): Remove prototype. * io/unit.h (next_available_newunit): Make variable static, initialize it. (init_units): Don't initialize next_av

[Patch, libfortran, committed] Return error when trying to seek a non-seekable buffered file

2011-06-11 Thread Janne Blomqvist
Hi, In libgfortran, buffered and unbuffered IO should work the same except for the buffering. For the unbuffered IO, seek and tell operations reduce to calls to lseek(). Thus, if the file is not seekable, they return -1 and set errno. Or strictly speaking, POSIX says that lseek() on a non-seekable

[Patch, libfortran, committed] Use lseek() to figure out if a file is seekable

2011-06-11 Thread Janne Blomqvist
Hi, currently we try to figure out whether a fd is seekable by looking at the mode returned by fstat(). Turns out this is not enough, as there are some character special files that are seekable. Thus, change the logic to try an lseek(). Committed as obvious. Index: ChangeLog

Re: [Patch, libfortran, committed] PR 48915 Update mixed-language programming section documentation

2011-05-15 Thread Janne Blomqvist
The previous patch was slightly over-zealous. Committed the following fix: Index: gfortran.texi === --- gfortran.texi (revision 173769) +++ gfortran.texi (working copy) @@ -2611,7 +2611,7 @@ standard error. Default: @code

[Patch, libfortran, committed] PR 48915 Update mixed-language programming section documentation

2011-05-14 Thread Janne Blomqvist
Hi, I committed the attached patch as obvious. It updates the manual section on mixed-language programming to reflect the changes made as part of PR 48915. Index: gfortran.texi === --- gfortran.texi (revision 173750) +++ gfortr

Re: [Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Janne Blomqvist
On Fri, Mar 4, 2011 at 20:06, Jakub Jelinek wrote: > On Fri, Mar 04, 2011 at 07:54:29PM +0200, Janne Blomqvist wrote: >> This should fix the problem reported on HP-UX 10.2. Committed as obvious: > > Well, it is not so obvious, you shouldn't be ignoring the return value from > strftime, because if

Re: [Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Jakub Jelinek
On Fri, Mar 04, 2011 at 07:54:29PM +0200, Janne Blomqvist wrote: > This should fix the problem reported on HP-UX 10.2. Committed as obvious: Well, it is not so obvious, you shouldn't be ignoring the return value from strftime, because if it fails, ltm will contain raondom undefined values. If ther

[Patch, libfortran, committed] PR 47802 Hack around POSIX draft localtime_r

2011-03-04 Thread Janne Blomqvist
This should fix the problem reported on HP-UX 10.2. Committed as obvious: Index: intrinsics/ctime.c === --- intrinsics/ctime.c (revision 170679) +++ intrinsics/ctime.c (working copy) @@ -39,9 +39,13 @@ static size_t strctime (char