Am 20.02.2018 um 20:10 schrieb Janne Blomqvist:
Shouldn't the second one be "stop 2"?
Corrected, r257859.
Regards
Thomas
On Tue, Feb 20, 2018 at 8:59 PM, Thomas Koenig wrote:
> Am 20.02.2018 um 08:51 schrieb Janne Blomqvist:
>
>> It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
>> mpz_get_si() returns a long, which is a 32-bit type on win64.
>>
>> Otherwise Ok with the spelling fix suggested by Steve.
>
Am 20.02.2018 um 08:51 schrieb Janne Blomqvist:
It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
mpz_get_si() returns a long, which is a 32-bit type on win64.
Otherwise Ok with the spelling fix suggested by Steve.
Committed as r257856.
Thanks to you and Steve for the review and
On Tue, Feb 20, 2018 at 09:51:14AM +0200, Janne Blomqvist wrote:
> On Tue, Feb 20, 2018 at 12:41 AM, Thomas Koenig wrote:
> > Hello world,
> >
> > when putting in a seemingly innocent simplification for PR 56342,
> > I caused a regression in PR 82823, in PACK. The root cause of
> > this one turned
On Tue, Feb 20, 2018 at 12:41 AM, Thomas Koenig wrote:
> Hello world,
>
> when putting in a seemingly innocent simplification for PR 56342,
> I caused a regression in PR 82823, in PACK. The root cause of
> this one turned out to be PR 48890, in which structure
> constructors containing characters
On Mon, Feb 19, 2018 at 11:41:30PM +0100, Thomas Koenig wrote:
>
> Regression-tested. OK for trunk?
>
OK with the fix suggested below.
> Index: primary.c
> ===
> --- primary.c (Revision 257788)
> +++ primary.c (Arbeitskopie)
> @@
Hello world,
when putting in a seemingly innocent simplification for PR 56342,
I caused a regression in PR 82823, in PACK. The root cause of
this one turned out to be PR 48890, in which structure
constructors containing characters were not handled correctly
if the lengths did not match.
The atta
