Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-25 Thread Thomas König
Hi Tobias, I hope my patch covers all issues. – OK for the trunk? Yep. Thanks a lot for the patch! Regards Thomas

*ping* Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-24 Thread Tobias Burnus
Admittedly an early PING. On 1/22/20 11:59 AM, Tobias Burnus wrote: Hi Thomas, hi all, first, I have now attached a different fix for PR 85781 (= original bug). Can you have a look? I have the feeling (but didn't check) that your patch does not handle the following variant of the test case:

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-22 Thread Tobias Burnus
Hi Steve, On 1/22/20 4:54 PM, Steve Kargl wrote: Supposedly, one can use attr.is_c_interop and attr.is_iso_c to determine if something is interoperable (if it is consistently set) and if it is from the ISO C Binding module. I think this is fixable on two sides: * For the used tree type, one

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-22 Thread Steve Kargl
On Wed, Jan 22, 2020 at 04:43:49PM +0100, Tobias Burnus wrote: > Hi Steve, > > On 1/22/20 4:02 PM, Steve Kargl wrote: > > On Wed, Jan 22, 2020 at 11:59:12AM +0100, Tobias Burnus wrote: > >> And, additionally, about missing diagnostic related to (2) bind(c) and > >> kind=4, > > Are you sure there i

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-22 Thread Tobias Burnus
Hi Steve, On 1/22/20 4:02 PM, Steve Kargl wrote: On Wed, Jan 22, 2020 at 11:59:12AM +0100, Tobias Burnus wrote: And, additionally, about missing diagnostic related to (2) bind(c) and kind=4, Are you sure there is a missing diagnostic? You need to add -Wc-binding-type or -Wall to your command

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-22 Thread Steve Kargl
On Wed, Jan 22, 2020 at 11:59:12AM +0100, Tobias Burnus wrote: > > And, additionally, about missing diagnostic related to (2) bind(c) and > kind=4, > Are you sure there is a missing diagnostic? You need to add -Wc-binding-type or -Wall to your command line. subroutine p(c) bind(c) use iso_c

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-22 Thread Tobias Burnus
Hi Thomas, hi all, first, I have now attached a different fix for PR 85781 (= original bug). Can you have a look? I have the feeling (but didn't check) that your patch does not handle the following variant of the test case: "print *, x(m:n)" (i.e. the lower bound is not known at compile time

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-21 Thread Thomas König
Hi Tobias, the attached patch fixes an ICE which could occur for empty substrings (see test case). I think one should rather fix the following issue. I am not sure what you mean. Does that mean that fixing the following issue will also fix PR 85781, or that the PR should not be fixed? Rega

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-20 Thread Tobias Burnus
On 1/20/20 1:31 PM, Tobias Burnus wrote: I think one should rather fix the following issue. That's now https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93336 Tobias

Re: [patch, fortran] Fix PR 85781, ICE on valid

2020-01-20 Thread Tobias Burnus
Hi Thomas, On 1/19/20 7:21 PM, Thomas König wrote: the attached patch fixes an ICE which could occur for empty substrings (see test case). I think one should rather fix the following issue. – While on x86-64 it does not seem to cause problems, it might for other platforms. Additionally, it i

[patch, fortran] Fix PR 85781, ICE on valid

2020-01-19 Thread Thomas König
Hello world, the attached patch fixes an ICE which could occur for empty substrings (see test case). In the spirit of "A patch that works beats an elegant idea every time" I simply set a substring known to be empty to (1:0) so that problems further down the road could be avoided. Regression-tes