Re: [patch, fortran] Correct fndecls for some library functions

2020-11-28 Thread Thomas Koenig via Gcc-patches
Am 27.11.20 um 16:46 schrieb Tobias Burnus: Hi Thomas, On 25.11.20 12:58, Tobias Burnus wrote: On 15.11.20 18:52, Thomas Koenig via Fortran wrote: +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0) ... +  ADD_CHAR ('.');  /* Function return.  */ Shouldn't this be ".c" instead of ".

Re: [patch, fortran] Correct fndecls for some library functions

2020-11-27 Thread Tobias Burnus
Hi Thomas, On 25.11.20 12:58, Tobias Burnus wrote: On 15.11.20 18:52, Thomas Koenig via Fortran wrote: +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0) ... + ADD_CHAR ('.'); /* Function return. */ Shouldn't this be ".c" instead of ". " as neither global memory is read nor writte

Re: [patch, fortran] Correct fndecls for some library functions

2020-11-25 Thread Tobias Burnus
Hello Thomas, On 15.11.20 18:52, Thomas Koenig via Fortran wrote: this patch makes sure that we pass the correct fn decls for some of our library functions. cshift and others still remain to be implemented. Thanks +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0) ... + ADD_CHAR ('

Re: *ping* [patch, fortran] Correct fndecls for some library functions

2020-11-23 Thread Thomas Koenig via Gcc-patches
Hi Iain, Is there some testcase that can be used to see a progression from applying this patch? I haven't been able to find anything. Previously, everything was passed as ". r r r r r r" and so on; there were also too many arguments for functions like findloc. Since "r " is the most conserva

Re: *ping* [patch, fortran] Correct fndecls for some library functions

2020-11-23 Thread Iain Sandoe via Gcc-patches
Hi Thomas. Thomas Koenig via Fortran wrote: this patch makes sure that we pass the correct fn decls for some of our library functions. cshift and others still remain to be implemented. This is a step in our voyage to stop lying to the middle end :-) Regression-tested. OK for trunk? Ping?

*ping* [patch, fortran] Correct fndecls for some library functions

2020-11-21 Thread Thomas Koenig via Gcc-patches
this patch makes sure that we pass the correct fn decls for some of our library functions. cshift and others still remain to be implemented. This is a step in our voyage to stop lying to the middle end :-) Regression-tested. OK for trunk? Ping? (I am not 100% sure this mail ever made it to

[patch, fortran] Correct fndecls for some library functions

2020-11-15 Thread Thomas Koenig via Gcc-patches
Hello world, this patch makes sure that we pass the correct fn decls for some of our library functions. cshift and others still remain to be implemented. This is a step in our voyage to stop lying to the middle end :-) Regression-tested. OK for trunk? Best regards Thomas Generate cor