Hi Tobias,
OK. Thanks for the patch after fixing the nit below.
Sorry for not noticing the review when you sent it.
Here is the patch as I committed it as Revision 196058.
2013-02-14 Thomas Koenig
PR fortran/56224
* gfortran.h (gfc_add_include_path): Add boolean argument
Thomas Koenig wrote:
*ping*
* pong *
I'd like to get this into 4.8 before release.
Others as well, given that it is a release-blocking P1 regression …
However, I have already approved it:
http://gcc.gnu.org/ml/fortran/2013-02/msg00061.html
Tobias
*ping*
I'd like to get this into 4.8 before release.
> This version of the patch should fix that particular issue, and also has
no test cases.
Regression-tested. OK?
I can leave out the FIXME if people object.
Thomas
Thomas Koenig wrote:
Am 09.02.2013 11:22, schrieb Tobias Burnus:
Why did you put a FIXME there? What's wrong with adding the directory
here?
I think module files are different enough from include files that I
would like to have them in different directories.
I think they are similar enough
On Sat, Feb 09, 2013 at 02:14:53PM +0100, Thomas Koenig wrote:
> Am 09.02.2013 11:22, schrieb Tobias Burnus:
>
> > Why did you put a FIXME there? What's wrong with adding the directory here?
>
> I think module files are different enough from include files that I
> would like to have them in diffe
Am 09.02.2013 11:22, schrieb Tobias Burnus:
Why did you put a FIXME there? What's wrong with adding the directory here?
I think module files are different enough from include files that I
would like to have them in different directories.
> "Seems to break testing, all testcases emit
> Warning
On Sat, Feb 09, 2013 at 11:22:18AM +0100, Tobias Burnus wrote:
> Are you sure that the test case in gfortran.dg/gomp/omp_lib_1.F
> works? The OpenMP Fortran headers (and modules) are generated in
> libgomp/. Thus, I am not sure they are available in
> gcc/testsuite/gfortran.dg/gomp (in particular w
Paul Richard Thomas wrote:
It looks OK to me - is Jakub OK with it?
On 8 February 2013 21:48, Thomas Koenig wrote:
the attached patch fixes the PR by (re-)adding a search path
for the path used by intrinsic modules.
Regression-tested. OK for trunk?
I am still recovering from a cold, but I
It looks OK to me - is Jakub OK with it?
Cheers
Paul
On 8 February 2013 21:48, Thomas Koenig wrote:
> Hello world,
>
> the attached patch fixes the PR by (re-)adding a search path
> for the path used by intrinsic modules.
>
> Regression-tested. OK for trunk?
>
> Thomas
>
> 2013-02-08
Hello world,
the attached patch fixes the PR by (re-)adding a search path
for the path used by intrinsic modules.
Regression-tested. OK for trunk?
Thomas
2013-02-08 Thomas Koenig
PR fortran/56224
* options.c (gfc_handle_option): Also call
gfc_add_include_p
10 matches
Mail list logo
