Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-25 Thread Bernhard Reutner-Fischer
On 24 September 2018 16:45:38 CEST, Cesar Philippidis wrote: >I updated the patch by incorporating all of those changes. Is it OK for >trunk? LGTM but I cannot approve it. thanks,

Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-24 Thread Cesar Philippidis
On 09/20/2018 09:10 AM, Bernhard Reutner-Fischer wrote: > On Thu, 20 Sep 2018 07:41:08 -0700 > Cesar Philippidis wrote: > >> On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: >>> On Wed, 5 Sep 2018 12:52:03 -0700 >>> Cesar Philippidis wrote: > diff --git a/gcc/fortran/trans-decl.c b/

Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-20 Thread Bernhard Reutner-Fischer
On Thu, 20 Sep 2018 07:41:08 -0700 Cesar Philippidis wrote: > On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: > > On Wed, 5 Sep 2018 12:52:03 -0700 > > Cesar Philippidis wrote: > >> diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c > >> index eea6b81ebfa..eed868f475b 1006

Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-20 Thread Cesar Philippidis
On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: > On Wed, 5 Sep 2018 12:52:03 -0700 > Cesar Philippidis wrote: > >> At present, gfortran does not encode the gang, worker or vector >> parallelism clauses when it creates acc routines dim attribute for >> subroutines and functions. While sup

Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-19 Thread Bernhard Reutner-Fischer
On Wed, 5 Sep 2018 12:52:03 -0700 Cesar Philippidis wrote: > At present, gfortran does not encode the gang, worker or vector > parallelism clauses when it creates acc routines dim attribute for > subroutines and functions. While support for acc routine is lacking in > other areas in gfortran (inc

[openacc] Teach gfortran to lower OpenACC routine dims

2018-09-05 Thread Cesar Philippidis
, Cesar [openacc] Teach gfortran to lower OpenACC routine dims gcc/fortran/ * gfortran.h (oacc_function): New enum. (gfc_oacc_routine_name): Add locus loc field. * openmp.c (gfc_oacc_routine_dims): Return oacc_function. (gfc_match_oacc_routine): Update routine clause syntax checking. Populate