Hi Prathamesh!
On 2024-09-23T08:24:36+, Prathamesh Kulkarni wrote:
> Thanks for the review and sorry for late reply.
No worries. My replies often are way more delayed... ;'-|
> The attached patch addresses the above suggestions.
> Does it look OK ?
ACK, thanks!
> (Also, could you please
> -Original Message-
> From: Thomas Schwinge
> Sent: Wednesday, September 4, 2024 3:15 PM
> To: Prathamesh Kulkarni ; Jan Hubicka
> ; gcc-patches@gcc.gnu.org
> Subject: Re: [nvptx] Fix code-gen for alias attribute
>
> External email: Use caution opening links o
Hi!
On 2024-09-04T11:45:20+0200, I wrote:
> On 2024-08-26T10:50:36+, Prathamesh Kulkarni
> wrote:
>> For the following test (adapted from pr96390.c):
>>
>> __attribute__((noipa)) int foo () { return 42; }
>> int bar () __attribute__((alias ("foo")));
>> int baz () __attribute__((alias ("bar"
Hi!
On 2024-09-04T11:45:20+0200, I wrote:
> +int bar () __attribute__((weak, alias ("foo")));
> Now, that said: GCC/nvptx for such code currently diagnoses
> "error: weak alias definitions not supported [...]" ;-|
Pushed to trunk branch commit 2267d254eb6ad782cef7b462f2bb2128bc8ace30
"Add 'g
...]" ;-| -- so we may be
safe, after all? ..., or is there any other way that the resolving to
'ultimate_alias_target' might cause issues? If not, then at least your
proposed patch shouldn't be causing any harm (doesn't affect
'--target=nvptx-none' test results at all..
> -Original Message-
> From: Prathamesh Kulkarni
> Sent: Monday, August 26, 2024 4:21 PM
> To: Thomas Schwinge ; gcc-patches@gcc.gnu.org
> Subject: [nvptx] Fix code-gen for alias attribute
>
> External email: Use caution opening links or attachments
>
>
>
the
provided value in nvptx_asm_output_def_from_decls.
For the above case, it now generates the following ptx:
.alias baz,foo;
instead of:
.alias baz,bar;
which fixes the issue.
Does the patch look in the right direction ?
Signed-off-by: Prathamesh Kulkarni
Thanks,
Prathamesh
[nvptx] Fix code-
