Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2020-03-02 Thread Martin Liška
On 2/27/20 7:55 AM, Roman Zhuykov wrote: Does anybody considered backporting this? I'm for the backport (after 8.4.0 will be released). I would like to get a permission from release managers about this patch? Martin

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2020-02-26 Thread Roman Zhuykov
Hi all! Does anybody considered backporting this? Given https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92410#c3 "Confirmed also with r247015 (GCC 7 branch point)." For example, we may apply it without an assertion in release branches. Roman 12.11.2019 12:11, Matthew Malcomson wrote: > In schedul

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-09 Thread Segher Boessenkool
On Mon, Dec 09, 2019 at 01:48:51PM +0100, Martin Liška wrote: > - gcc_assert (INSN_UID (insn) < DF_INSN_SIZE ()); > + gcc_assert (INSN_UID (insn) < (int)DF_INSN_SIZE ()); Space after cast please. Segher

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-09 Thread Matthew Malcomson
Ah, apologies -- you're right. I'd already committed the patch this morning, so I'll update it with the obvious fix. Thanks for the catch, Matthew On 09/12/2019 12:48, Martin Liška wrote: > Hello. > > The patch triggers the following warning: > > In file included from /home/marxin/Programming

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-09 Thread Matthew Malcomson
Ah, apologies -- you're right. I'd already committed the patch this morning, so I'll update it with the obvious fix. Thanks for the catch, Matthew On 09/12/2019 12:48, Martin Liška wrote: > Hello. > > The patch triggers the following warning: > > In file included from /home/marxin/Programming

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-09 Thread Martin Liška
Hello. The patch triggers the following warning: In file included from /home/marxin/Programming/gcc/gcc/regstat.c:23: /home/marxin/Programming/gcc/gcc/regstat.c: In function ‘void regstat_bb_compute_calls_crossed(unsigned int, bitmap)’: /home/marxin/Programming/gcc/gcc/regstat.c:327:35: warning

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-06 Thread Jeff Law
On Tue, 2019-11-12 at 09:11 +, Matthew Malcomson wrote: > In scheduling passes, notes are removed with `remove_notes` before > the > > scheduling is done, and added back in with `reemit_notes` once the > > scheduling has been decided. > > > > This process leaves the notes in the RTL chain

Re: [mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-12-02 Thread Matthew Malcomson
Ping On 12/11/2019 09:11, Matthew Malcomson wrote: > In scheduling passes, notes are removed with `remove_notes` before the > scheduling is done, and added back in with `reemit_notes` once the > scheduling has been decided. > > This process leaves the notes in the RTL chain with different insn ui

[mid-end] Add notes to dataflow insn info when re-emitting (PR92410)

2019-11-12 Thread Matthew Malcomson
In scheduling passes, notes are removed with `remove_notes` before the scheduling is done, and added back in with `reemit_notes` once the scheduling has been decided. This process leaves the notes in the RTL chain with different insn uid's than were there before. Having different UID's (larger th