Re: [lra] patch to fix GCC crash on a SPEC2006 test

2012-10-14 Thread Vladimir Makarov
On 12-10-13 11:37 AM, Peter Bergner wrote: On Thu, 2012-10-11 at 23:53 -0400, Vladimir Makarov wrote: Is the following comment better? Presence of any pseudo in CALL_INSN_FUNCTION_USAGE does not affect value of insn_bitmap of the corresponding lra_reg_info. That is because we don't need to rel

Re: [lra] patch to fix GCC crash on a SPEC2006 test

2012-10-13 Thread Peter Bergner
On Thu, 2012-10-11 at 23:53 -0400, Vladimir Makarov wrote: > My biggest problem is ESL. I should use simpler phrases. Heh, I'm not sure compiler speak qualifies as English. :) > Is the following comment better? > > Presence of any pseudo in CALL_INSN_FUNCTION_USAGE does not affect value > of

Re: [lra] patch to fix GCC crash on a SPEC2006 test

2012-10-11 Thread Vladimir Makarov
On 12-10-11 12:56 PM, Peter Bergner wrote: On Thu, 2012-10-11 at 11:35 -0400, Vladimir Makarov wrote: + /* Call insn might have not references for pseudos besides +in CALL_INSN_FUNCTION_USAGE but we don't count them in +insn_bitmap of corresponding lra_reg_info as

Re: [lra] patch to fix GCC crash on a SPEC2006 test

2012-10-11 Thread Peter Bergner
On Thu, 2012-10-11 at 11:35 -0400, Vladimir Makarov wrote: > + /* Call insn might have not references for pseudos besides > +in CALL_INSN_FUNCTION_USAGE but we don't count them in > +insn_bitmap of corresponding lra_reg_info as they don't > +need reloads.

[lra] patch to fix GCC crash on a SPEC2006 test

2012-10-11 Thread Vladimir Makarov
The following patch fixes scheduler crash on a SPEC2006 test because LRA did not process CALL_INSN_FUNCTION_USAGE. The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 192362. 2012-10-11 Vladimir Makarov * lra-spills.c (spill_pseudos): Process CALL_IN