Re: [line-map patch] Better packing of maps

2018-06-26 Thread Nathan Sidwell
On 06/26/2018 03:31 PM, David Malcolm wrote: Which assert are you referring to? Hm, I think I may have been confused by the unsigned arithmetic check in: if (start_location <= set->highest_line || start_location > LINEMAPS_MACRO_LOWEST_LOCATION (set)) /* We ran out of macro map spa

Re: [line-map patch] Better packing of maps

2018-06-26 Thread David Malcolm
On Tue, 2018-06-26 at 14:28 -0400, Nathan Sidwell wrote: > I've been wandering around the line-map machinery on the modules > branch. > One thing I noticed was the padding of the line_map type hierarchy > was > unfortunate. That made me sad. This patch fixes that. > > Rather than keep the th

[line-map patch] Better packing of maps

2018-06-26 Thread Nathan Sidwell
I've been wandering around the line-map machinery on the modules branch. One thing I noticed was the padding of the line_map type hierarchy was unfortunate. That made me sad. This patch fixes that. Rather than keep the the reason field in line_map, I move it to line_map_ordinary. That allo