Re: [line-map] simple oneliner that speeds up track-macro-expansion

2012-06-05 Thread Jason Merrill
Applied, thanks. Jason

Re: [line-map] simple oneliner that speeds up track-macro-expansion

2012-06-05 Thread Dodji Seketeli
Dimitrios Apostolou writes: > Hi Dodji, > > On Mon, 4 Jun 2012, Dodji Seketeli wrote: > >> Hello Dimitrios, >> >> I cannot approve or deny your patch, but I have one question. >> > > Who should I CC then? Do not worry, I am CC-ing the maintainers. I just forgot to CC them when I replied. Sorr

Re: [line-map] simple oneliner that speeds up track-macro-expansion

2012-06-04 Thread Dimitrios Apostolou
Hi Dodji, On Mon, 4 Jun 2012, Dodji Seketeli wrote: Hello Dimitrios, I cannot approve or deny your patch, but I have one question. Who should I CC then? I saw that you have commits in that file. I am wondering why this change implies better performance. Is this because when we later want

Re: [line-map] simple oneliner that speeds up track-macro-expansion

2012-06-04 Thread Dodji Seketeli
Hello Dimitrios, I cannot approve or deny your patch, but I have one question. [...] > 2012-06-04 Dimitrios Apostolou > > * line-map.c (linemap_enter_macro): Don't zero max_column_hint in > every macro. This improves performance by reducing the number of > reallocations whe

[line-map] simple oneliner that speeds up track-macro-expansion

2012-06-03 Thread Dimitrios Apostolou
Hello list, the attached simple patch is a small part of the fix in Bug #53525, but it is independant and offers a noticeable performance improvement for track-macro-expansion. No regressions tested on x86, besides memory usage going up some KB. I don't get why the max_column_hint was zeroed