Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-09 Thread FX
>> In the apparent absence of the libquadmath maintainers, could a global >> reviewer approve this rather simple patch, please? > > OK Committed as rev. 226748. Thanks. FX

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-09 Thread Paul Richard Thomas
Sorry - I missed the "global" Paul On 9 August 2015 at 09:08, Paul Richard Thomas wrote: > Dear FX, > > I looks OK to me - as you say, it's rather simple. Good for trunk. > > Thanks for the patch > > Paul > > On 9 August 2015 at 08:27, FX wrote: >> ping >> >> In the apparent absence of the libq

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-09 Thread Richard Biener
On August 9, 2015 8:27:09 AM GMT+02:00, FX wrote: >ping > >In the apparent absence of the libquadmath maintainers, could a global >reviewer approve this rather simple patch, please? OK Richard > > >> The attached patch adds logbq() to libquadmath, with code lifted from >glibc. >> It is made nec

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-09 Thread Paul Richard Thomas
Dear FX, I looks OK to me - as you say, it's rather simple. Good for trunk. Thanks for the patch Paul On 9 August 2015 at 08:27, FX wrote: > ping > > In the apparent absence of the libquadmath maintainers, could a global > reviewer approve this rather simple patch, please? > > > >> The attach

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-08 Thread FX
ping In the apparent absence of the libquadmath maintainers, could a global reviewer approve this rather simple patch, please? > The attached patch adds logbq() to libquadmath, with code lifted from glibc. > It is made necessary by an upcoming patch for gfortran, adding full support > for th

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-06 Thread FX
> With the updated patch the test gfortran.dg/ieee/large_1.f90 compiles, but > fails at run time due to the lines > > if (.not. ieee_support_underflow_control(x1)) call abort > > and > > if (.not. ieee_support_underflow_control(x2)) call abort > > IIRC Uros said that underflow id not support

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread Dominique d'Humières
> Le 5 août 2015 à 15:11, FX a écrit : > >> AFAICT there is something missing in the patch: I do not see any compilation >> of math/logbq.c and indeed no trace of logbq in libquadmath. What I am >> missing? > > Maybe you didn’t regenerate the Makefile.in? Indeed I did not!-(I have never succ

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread FX
> AFAICT there is something missing in the patch: I do not see any compilation > of math/logbq.c and indeed no trace of logbq in libquadmath. What I am > missing? Maybe you didn’t regenerate the Makefile.in? The patch was sent without this regenerated file, as is (as I understand) the custom on

Re: [libquadmath, patch] Add logbq() to libquadmath

2015-08-05 Thread Dominique d'Humières
> The attached patch adds logbq() to libquadmath, with code lifted from glibc. AFAICT there is something missing in the patch: I do not see any compilation of math/logbq.c and indeed no trace of logbq in libquadmath. What I am missing? TIA Dominique

[libquadmath, patch] Add logbq() to libquadmath

2015-08-03 Thread FX
The attached patch adds logbq() to libquadmath, with code lifted from glibc. It is made necessary by an upcoming patch for gfortran, adding full support for the IEEE modules on __float128, and requires logbq(). Bootstrapped and regtested on x86_64-apple-darwin14. OK to commit to trunk? FX log