Re: [libcpp PATCH] Fix up location of builtin macros (PR c/61861)

2014-07-25 Thread Jeff Law
On 07/23/14 07:15, Marek Polacek wrote: Bultin macros like __FILE__, __DATE__, etc. had wrong locus - always column 1. This patch fixes it by giving those macros location of the expansion point, i.e, the location, where builtin macro is used. It now also does the correct thing if we do e.g. #def

Re: [libcpp PATCH] Fix up location of builtin macros (PR c/61861)

2014-07-23 Thread Marek Polacek
[Though Dodji is on a vacation for next two weeks, so if anyone else can review this patch, it would be appreciated.] On Wed, Jul 23, 2014 at 05:39:51PM +0200, Marek Polacek wrote: > CCing Dodji, please, can you have a look? (I don't believe it is > caused by yours > https://gcc.gnu.org/ml/gcc-pa

Re: [libcpp PATCH] Fix up location of builtin macros (PR c/61861)

2014-07-23 Thread Marek Polacek
CCing Dodji, please, can you have a look? (I don't believe it is caused by yours https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01063.html though, this was wrong even in 4.8 and maybe earlier.) On Wed, Jul 23, 2014 at 03:15:53PM +0200, Marek Polacek wrote: > Bultin macros like __FILE__, __DATE__,

[libcpp PATCH] Fix up location of builtin macros (PR c/61861)

2014-07-23 Thread Marek Polacek
Bultin macros like __FILE__, __DATE__, etc. had wrong locus - always column 1. This patch fixes it by giving those macros location of the expansion point, i.e, the location, where builtin macro is used. It now also does the correct thing if we do e.g. #define F __FILE__. Bootstrapped/regtested on