Re: [libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)

2015-06-05 Thread Marek Polacek
On Thu, Jun 04, 2015 at 09:05:51PM +, Joseph Myers wrote: > OK in the absence of objections from Dodji as line map maintainer within > 48 hours. Thanks. [Adding Dodji to CC.] Marek

Re: [libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)

2015-06-04 Thread Joseph Myers
On Thu, 4 Jun 2015, Marek Polacek wrote: > This patch fixes two issues in locations with offsets that these two > new tests revealed: > 1) we should check the return value of location_get_source_line; > 2) linemap_position_for_loc_and_offset can be confused if a location >is in a different map

[libcpp/C PATCH] Fix two ICEs with location offsets (PR c/66415)

2015-06-04 Thread Marek Polacek
This patch fixes two issues in locations with offsets that these two new tests revealed: 1) we should check the return value of location_get_source_line; 2) linemap_position_for_loc_and_offset can be confused if a location is in a different map than it expects it to be. Proper fix is unknown